From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from wtarreau.pck.nerim.net ([62.212.114.60]:33069 "EHLO 1wt.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759656AbcLPKlM (ORCPT ); Fri, 16 Dec 2016 05:41:12 -0500 Date: Fri, 16 Dec 2016 11:40:32 +0100 From: Willy Tarreau To: Mike Manning Cc: stable@vger.kernel.org, hannes@stressinduktion.org Subject: Re: [PATCH 3.10] ipv6: move DAD and addrconf_verify processing to workqueue Message-ID: <20161216104032.GA12172@1wt.eu> References: <1481883372-26591-1-git-send-email-mmanning@brocade.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481883372-26591-1-git-send-email-mmanning@brocade.com> Sender: stable-owner@vger.kernel.org List-ID: Hi Mike, On Fri, Dec 16, 2016 at 10:16:12AM +0000, Mike Manning wrote: > From: Hannes Frederic Sowa > > commit c15b1ccadb323ea50023e8f1cca2954129a62b51 upstream. > > addrconf_join_solict and addrconf_join_anycast may cause actions which > need rtnl locked, especially on first address creation. (...) Thanks, I'm fine with merging these patches, but a quick check tells me that at least the first one caused some issues that were later fixed, for example : From 43a43b6040165f7b40b5b489fe61a4cb7f8c4980 Mon Sep 17 00:00:00 2001 From: Hannes Frederic Sowa Date: Mon, 31 Mar 2014 20:14:10 +0200 Subject: [PATCH] ipv6: some ipv6 statistic counters failed to disable bh After commit c15b1ccadb323ea ("ipv6: move DAD and addrconf_verify processing to workqueue") some counters are now updated in process context and thus need to disable bh before doing so, otherwise deadlocks can happen on 32-bit archs. Fabio Estevam noticed this while while mounting a NFS volume on an ARM board. Can you please have a quick check to ensure that all necessary fixes that come with these two patches are also identified ? I'll then queue them all at once. Thanks! Willy