From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org, Shreyansh Jain <shreyansh.jain@nxp.com>,
Stephen Hemminger <sthemmin@microsoft.com>
Subject: Re: [PATCH 2/2] hyperv: VMBUS support infrastucture
Date: Fri, 16 Dec 2016 12:15:22 -0800 [thread overview]
Message-ID: <20161216121522.58281062@xeon-e3> (raw)
In-Reply-To: <17034171.EHDWhStFHz@xps13>
On Fri, 16 Dec 2016 19:09:02 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2016-12-15 09:26, Stephen Hemminger:
> > On Thu, 15 Dec 2016 12:19:44 +0530
> > Shreyansh Jain <shreyansh.jain@nxp.com> wrote:
> > > It is not a scale-able model where we have to change eth_driver/eth_dev
> > > for every new device type, other than PCI. Maybe VMBus is _very_ close
> > > to PCI so no changes are required in PCI layer (common, linuxapp,
> > > bsdapp) - but, for others it won't stop there.
> > >
> > > At the least, rte_pci_driver/rte_pci_device should be removed from
> > > eth_driver & rte_eth_dev, respectively - relying on rte_driver and
> > > rte_device.
> > >
> > > This is the primary reason work on the SoC patchset and now the new Bus
> > > model is being done.
> >
> > Agreed. the better long term model is to use C style inheritance where
> > rte_pci_driver has eth_driver inside.
> > The other alternative is to make the second element an opaque pointer.
> >
> > But that was too big a change, and not necessary to get VMBUS to work.
> > Longer term refactoring will take more effort. Go ahead and address it
> > with a better bus model, but that probably isn't going to be ready for
> > a couple of releases.
>
> We'll consider only the approach of generalizing the bus model for integr ation.
> Stephen, you are welcome to help make it happen and rebase your work
> on top of this new model.
> Thanks
I will generalize it to PCI and VMBUS only. I am not inventing a generic SOC
model since that is something that I don't have sufficient knowledge. This
fits the YAGNI principle.
next prev parent reply other threads:[~2016-12-16 20:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 23:59 [PATCH 0/2] support for Hyper-V VMBUS Stephen Hemminger
2016-12-14 23:59 ` [PATCH 1/2] ethdev: increase length ethernet device internal name Stephen Hemminger
2016-12-14 23:59 ` [PATCH 2/2] hyperv: VMBUS support infrastucture Stephen Hemminger
2016-12-15 6:49 ` Shreyansh Jain
2016-12-15 17:26 ` Stephen Hemminger
2016-12-16 18:09 ` Thomas Monjalon
2016-12-16 20:15 ` Stephen Hemminger [this message]
2016-12-17 9:17 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216121522.58281062@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=shreyansh.jain@nxp.com \
--cc=sthemmin@microsoft.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.