From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v2 05/11] locking/ww_mutex: Add waiters in stamp order Date: Fri, 16 Dec 2016 21:00:23 +0100 Message-ID: <20161216200023.GH3124@twins.programming.kicks-ass.net> References: <1480601214-26583-1-git-send-email-nhaehnle@gmail.com> <1480601214-26583-6-git-send-email-nhaehnle@gmail.com> <20161206165544.GX3045@worktop.programming.kicks-ass.net> <20161216171524.GU3107@twins.programming.kicks-ass.net> <98cfeb6e-f312-ba13-00b4-f5b125b24f8d@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2001:1868:205::9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 832196ED28 for ; Fri, 16 Dec 2016 20:09:45 +0000 (UTC) Content-Disposition: inline In-Reply-To: <98cfeb6e-f312-ba13-00b4-f5b125b24f8d@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Nicolai =?iso-8859-1?Q?H=E4hnle?= Cc: Maarten Lankhorst , Nicolai =?iso-8859-1?Q?H=E4hnle?= , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Ingo Molnar List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBEZWMgMTYsIDIwMTYgYXQgMDc6MTE6NDFQTSArMDEwMCwgTmljb2xhaSBIw6Robmxl IHdyb3RlOgo+IG11dGV4X29wdGltaXN0aWNfc3BpbigpIGFscmVhZHkgY2FsbHMgX19tdXRleF90 cnlsb2NrLCBhbmQgZm9yIHRoZSBuby1zcGluCj4gY2FzZSwgX19tdXRleF91bmxvY2tfc2xvd3Bh dGgoKSBvbmx5IGNhbGxzIHdha2VfdXBfcSgpIGFmdGVyIHJlbGVhc2luZyB0aGUKPiB3YWl0X2xv Y2suCgptdXRleF9vcHRpbWlzdGljX3NwaW4oKSBpcyBhIG5vLW9wIHdoZW4gIUNPTkZJR19NVVRF WF9TUElOX09OX09XTkVSCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932981AbcLPUKX (ORCPT ); Fri, 16 Dec 2016 15:10:23 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:39515 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758284AbcLPUJ6 (ORCPT ); Fri, 16 Dec 2016 15:09:58 -0500 Date: Fri, 16 Dec 2016 21:00:23 +0100 From: Peter Zijlstra To: Nicolai =?iso-8859-1?Q?H=E4hnle?= Cc: linux-kernel@vger.kernel.org, Nicolai =?iso-8859-1?Q?H=E4hnle?= , Ingo Molnar , Maarten Lankhorst , Daniel Vetter , Chris Wilson , dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2 05/11] locking/ww_mutex: Add waiters in stamp order Message-ID: <20161216200023.GH3124@twins.programming.kicks-ass.net> References: <1480601214-26583-1-git-send-email-nhaehnle@gmail.com> <1480601214-26583-6-git-send-email-nhaehnle@gmail.com> <20161206165544.GX3045@worktop.programming.kicks-ass.net> <20161216171524.GU3107@twins.programming.kicks-ass.net> <98cfeb6e-f312-ba13-00b4-f5b125b24f8d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98cfeb6e-f312-ba13-00b4-f5b125b24f8d@gmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 16, 2016 at 07:11:41PM +0100, Nicolai Hähnle wrote: > mutex_optimistic_spin() already calls __mutex_trylock, and for the no-spin > case, __mutex_unlock_slowpath() only calls wake_up_q() after releasing the > wait_lock. mutex_optimistic_spin() is a no-op when !CONFIG_MUTEX_SPIN_ON_OWNER