From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Alistair Francis <alistair.francis@xilinx.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com,
imhy.yang@gmail.com, alistair23@gmail.com, rshriram@cs.ubc.ca,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats
Date: Sat, 17 Dec 2016 10:57:32 -0500 [thread overview]
Message-ID: <20161217155731.GH2267@localhost.localdomain> (raw)
In-Reply-To: <1481928967-4130-7-git-send-email-alistair.francis@xilinx.com>
On Fri, Dec 16, 2016 at 02:56:06PM -0800, Alistair Francis wrote:
> The unsued variable 'struct stat stats' causes build errors in some
> situations. As it isn't used just remove it.
I think there is an patch that will just rip the blktap2 source
code out altogether..
But if that is not yet in, so
>
> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> ---
> tools/blktap2/vhd/lib/libvhd-journal.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/blktap2/vhd/lib/libvhd-journal.c b/tools/blktap2/vhd/lib/libvhd-journal.c
> index 26e26e7..862890f 100644
> --- a/tools/blktap2/vhd/lib/libvhd-journal.c
> +++ b/tools/blktap2/vhd/lib/libvhd-journal.c
> @@ -1260,7 +1260,6 @@ vhd_journal_create(vhd_journal_t *j, const char *file, const char *jfile)
> int i, err;
> size_t size;
> off_t off;
> - struct stat stats;
>
> memset(j, 0, sizeof(vhd_journal_t));
> j->jfd = -1;
> --
> 2.7.4
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-17 15:57 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
2016-12-16 22:56 ` [PATCH 1/7] Remove hardcoded strict -Werror checking Alistair Francis
2016-12-17 15:51 ` Konrad Rzeszutek Wilk
2016-12-19 17:58 ` Alistair Francis
2016-12-20 3:53 ` Doug Goldstein
2016-12-20 16:05 ` Konrad Rzeszutek Wilk
2016-12-20 17:02 ` Doug Goldstein
2016-12-20 17:21 ` Konrad Rzeszutek Wilk
2016-12-20 17:57 ` Alistair Francis
2016-12-20 17:58 ` Alistair Francis
2016-12-16 22:56 ` [PATCH 2/7] tools/libxl: " Alistair Francis
2016-12-17 15:52 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment Alistair Francis
2016-12-17 15:54 ` Konrad Rzeszutek Wilk
2016-12-19 8:32 ` Jan Beulich
2016-12-16 22:56 ` [PATCH 4/7] tools: Update sys/poll.h to poll.h Alistair Francis
2016-12-17 15:55 ` Konrad Rzeszutek Wilk
2016-12-19 18:01 ` Alistair Francis
2016-12-20 4:00 ` Doug Goldstein
2016-12-20 17:44 ` Alistair Francis
2016-12-16 22:56 ` [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h Alistair Francis
2016-12-17 15:56 ` Konrad Rzeszutek Wilk
2016-12-19 18:02 ` Alistair Francis
2016-12-20 4:01 ` Doug Goldstein
2016-12-16 22:56 ` [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats Alistair Francis
2016-12-17 15:57 ` Konrad Rzeszutek Wilk [this message]
2016-12-16 22:56 ` [PATCH 7/7] tools/blktap2: Fix missing header file Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161217155731.GH2267@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=imhy.yang@gmail.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.