From: "Linus Lüssing" <linus.luessing@c0d3.blue>
To: The list for a Better Approach To Mobile Ad-hoc Networking
<b.a.t.m.a.n@lists.open-mesh.org>
Subject: Re: [B.A.T.M.A.N.] [PATCH v2 2/4] batman-adv: Store and transmit own neighborhood hash
Date: Mon, 19 Dec 2016 14:32:26 +0100 [thread overview]
Message-ID: <20161219133226.GM6323@otheros> (raw)
In-Reply-To: <740883563.LbP4XMaFY9@sven-edge>
On Wed, Dec 14, 2016 at 09:28:33PM +0100, Sven Eckelmann wrote:
> On Donnerstag, 6. Oktober 2016 08:41:39 CET Linus Lüssing wrote:
> > struct batadv_elp_packet {
> > u8 packet_type;
> > @@ -247,6 +258,8 @@ struct batadv_elp_packet {
> > u8 orig[ETH_ALEN];
> > __be32 seqno;
> > __be32 elp_interval;
> > + __be16 reserved;
> > + __be16 tvlv_len;
> > };
>
> Um, you simply increase the size of the elp_packet? Isn't this potentially
> breaking compat with older versions? batadv_v_elp_packet_recv is using
> BATADV_ELP_HLEN (sizeof(struct batadv_elp_packet)) as minimal size/header_len
> in batadv_check_management_packet.
>
> Only thing saving you here is the padding on some links. But this padding
> could cause some odd behaviour in batadv_tvlv_containers_process2 when
> tvlv_len is bogus/padding.
Urgh, could catch, you're right.
Luckily, it seems like it's only breaking compatibility in one direction.
And it's the direction where a non-compatibility breaking solution
is possible.
next prev parent reply other threads:[~2016-12-19 13:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 6:41 [B.A.T.M.A.N.] [PATCH v2 0/4] Broadcast Avoidances, Neighborhood Hash Linus Lüssing
2016-10-06 6:41 ` [B.A.T.M.A.N.] [PATCH v2 1/4] batman-adv: Keep hard interface neighbor list sorted Linus Lüssing
2016-12-14 18:48 ` Sven Eckelmann
2016-12-14 19:23 ` Sven Eckelmann
2017-01-28 3:13 ` Linus Lüssing
2017-01-28 3:40 ` Linus Lüssing
2017-01-28 9:07 ` Sven Eckelmann
2016-10-06 6:41 ` [B.A.T.M.A.N.] [PATCH v2 2/4] batman-adv: Store and transmit own neighborhood hash Linus Lüssing
2016-12-14 20:28 ` Sven Eckelmann
2016-12-19 13:32 ` Linus Lüssing [this message]
2016-12-14 20:49 ` Sven Eckelmann
2016-12-14 20:57 ` Sven Eckelmann
2016-10-06 6:41 ` [B.A.T.M.A.N.] [PATCH v2 3/4] batman-adv: Introduce packet type independent TVLV handler API Linus Lüssing
2016-12-14 14:50 ` Sven Eckelmann
2016-12-19 10:29 ` Linus Lüssing
2017-01-22 12:40 ` Sven Eckelmann
2016-12-14 20:03 ` Sven Eckelmann
2016-12-14 20:12 ` Sven Eckelmann
2016-12-19 10:50 ` Linus Lüssing
2016-12-19 11:37 ` Sven Eckelmann
2016-12-19 11:43 ` Sven Eckelmann
2016-12-20 11:55 ` Linus Lüssing
2017-01-22 12:51 ` Sven Eckelmann
2016-10-06 6:41 ` [B.A.T.M.A.N.] [PATCH v2 4/4] batman-adv: Evaluate and use neighborhood hash TVLV Linus Lüssing
2016-12-14 14:49 ` [B.A.T.M.A.N.] [PATCH v2 0/4] Broadcast Avoidances, Neighborhood Hash Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219133226.GM6323@otheros \
--to=linus.luessing@c0d3.blue \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.