From: "Radim Krčmář" <rkrcmar@redhat.com>
To: David Matlack <dmatlack@google.com>
Cc: kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
pbonzini@redhat.com, peterz@infradead.org, haokexin@gmail.com,
mpe@ellerman.id.au, yongjun_wei@trendmicro.com.cn,
rusty@rustcorp.com.au, jbaron@akamai.com
Subject: Re: [PATCH 2/2] KVM: x86: flush pending lapic jump label updates on module unload
Date: Mon, 19 Dec 2016 15:24:05 +0100 [thread overview]
Message-ID: <20161219142404.GA21302@potion> (raw)
In-Reply-To: <1481927436-104568-2-git-send-email-dmatlack@google.com>
2016-12-16 14:30-0800, David Matlack:
> KVM's lapic emulation uses static_key_deferred (apic_{hw,sw}_disabled).
> These are implemented with delayed_work structs which can still be
> pending when the KVM module is unloaded. We've seen this cause kernel
> panics when the kvm_intel module is quickly reloaded.
>
> Use the new static_key_deferred_flush() API to flush pending updates on
> module unload.
>
> Signed-off-by: David Matlack <dmatlack@google.com>
> ---
Oh, this forgotten bug. I guess that patches to do this automatically
from generic module unload code would be over-engineering it ...
Reviewed-by: Radim Krčmář <rkrcmar@redhat.com>
Thanks.
next prev parent reply other threads:[~2016-12-19 14:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 22:30 [PATCH 1/2] jump_labels: API for flushing deferred jump label updates David Matlack
2016-12-16 22:30 ` [PATCH 2/2] KVM: x86: flush pending lapic jump label updates on module unload David Matlack
2016-12-19 14:24 ` Radim Krčmář [this message]
2016-12-19 14:58 ` [PATCH 1/2] jump_labels: API for flushing deferred jump label updates Peter Zijlstra
2016-12-22 12:35 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161219142404.GA21302@potion \
--to=rkrcmar@redhat.com \
--cc=dmatlack@google.com \
--cc=haokexin@gmail.com \
--cc=jbaron@akamai.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
--cc=pbonzini@redhat.com \
--cc=peterz@infradead.org \
--cc=rusty@rustcorp.com.au \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.