From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH 3/6] libxcmd: merge command() and iterate_command()
Date: Tue, 20 Dec 2016 00:31:19 -0800 [thread overview]
Message-ID: <20161220083119.GA12768@infradead.org> (raw)
In-Reply-To: <20161216044115.21287-4-david@fromorbit.com>
On Fri, Dec 16, 2016 at 03:41:12PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Simplify the command loop further by merging the command loop
> iteration checks with the command execution function. This removes
> all visibility of command iteration from the main command execution
> loop, and enables us to factor and clean up the command loop
> processing neatly.
>
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>
Looks fine, but some minor nitpicks below:
Signed-off-by: Christoph Hellwig <hch@lst.de>
> +static int
> +process_input(
return bool instead of int (and switch done in the caller to bool as
well)?
> + char *input,
> + bool iterate)
> {
> - int c, i, j = 0, done = 0;
> - char *input;
Align the arguments to the same row as the variables below it?
next prev parent reply other threads:[~2016-12-20 8:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 4:41 [PATCH v2 0/6] xfs_io: fix up command iteration Dave Chinner
2016-12-16 4:41 ` [PATCH 1/6] libxcmd: check CMD_FLAG_GLOBAL inside args_command() Dave Chinner
2016-12-20 8:26 ` Christoph Hellwig
2016-12-16 4:41 ` [PATCH 2/6] libxcmd: rename args_command to command_iterator Dave Chinner
2016-12-20 8:27 ` Christoph Hellwig
2016-12-16 4:41 ` [PATCH 3/6] libxcmd: merge command() and iterate_command() Dave Chinner
2016-12-20 8:31 ` Christoph Hellwig [this message]
2016-12-20 20:11 ` Eric Sandeen
2016-12-21 9:38 ` Christoph Hellwig
2016-12-16 4:41 ` [PATCH 4/6] libxcmd: don't check generic library commands Dave Chinner
2016-12-20 8:34 ` Christoph Hellwig
2016-12-16 4:41 ` [PATCH 5/6] xfs_io: make various commands one-shot only Dave Chinner
2016-12-20 8:44 ` Christoph Hellwig
2016-12-16 4:41 ` [PATCH 6/6] libxcmd: add non-iterating user commands Dave Chinner
2016-12-16 6:39 ` Amir Goldstein
-- strict thread matches above, loose matches on Subject: below --
2016-12-07 3:47 [PATCH 0/6] xfs_io: fix up command iteration Dave Chinner
2016-12-07 3:47 ` [PATCH 3/6] libxcmd: merge command() and iterate_command() Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220083119.GA12768@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.