From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawnguo@kernel.org (Shawn Guo) Date: Tue, 20 Dec 2016 20:04:52 +0800 Subject: [PATCH] drm: zte: add overlay plane support In-Reply-To: <20161208155755.GY31595@intel.com> References: <1481166761-5100-1-git-send-email-shawnguo@kernel.org> <20161208155755.GY31595@intel.com> Message-ID: <20161220120451.GC8787@dragon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Ville, On Thu, Dec 08, 2016 at 05:57:55PM +0200, Ville Syrj?l? wrote: > On Thu, Dec 08, 2016 at 11:12:41AM +0800, Shawn Guo wrote: > > > +static void zx_vl_plane_atomic_update(struct drm_plane *plane, > > + struct drm_plane_state *old_state) > > +{ > > + struct zx_plane *zplane = to_zx_plane(plane); > > + struct drm_framebuffer *fb = plane->state->fb; > > + struct drm_gem_cma_object *cma_obj; > > + void __iomem *layer = zplane->layer; > > + void __iomem *hbsc = zplane->hbsc; > > + void __iomem *paddr_reg; > > + dma_addr_t paddr; > > + u32 src_x, src_y, src_w, src_h; > > + u32 dst_x, dst_y, dst_w, dst_h; > > + uint32_t format; > > + u32 fmt; > > + int num_planes; > > + int i; > > + > > + if (!fb) > > + return; > > + > > + format = fb->pixel_format; > > + > > + src_x = plane->state->src_x >> 16; > > + src_y = plane->state->src_y >> 16; > > + src_w = plane->state->src_w >> 16; > > + src_h = plane->state->src_h >> 16; > > + > > + dst_x = plane->state->crtc_x; > > + dst_y = plane->state->crtc_y; > > + dst_w = plane->state->crtc_w; > > + dst_h = plane->state->crtc_h; > > This shouls use the clipped coordiantes. Thanks for spotting this. I will fix it in v2. Shawn From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shawn Guo Subject: Re: [PATCH] drm: zte: add overlay plane support Date: Tue, 20 Dec 2016 20:04:52 +0800 Message-ID: <20161220120451.GC8787@dragon> References: <1481166761-5100-1-git-send-email-shawnguo@kernel.org> <20161208155755.GY31595@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6285E6E96F for ; Tue, 20 Dec 2016 12:05:21 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161208155755.GY31595@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Cc: Daniel Vetter , Jun Nie , Baoyou Xie , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGkgVmlsbGUsCgpPbiBUaHUsIERlYyAwOCwgMjAxNiBhdCAwNTo1Nzo1NVBNICswMjAwLCBWaWxs ZSBTeXJqw6Rsw6Qgd3JvdGU6Cj4gT24gVGh1LCBEZWMgMDgsIDIwMTYgYXQgMTE6MTI6NDFBTSAr MDgwMCwgU2hhd24gR3VvIHdyb3RlOgo+IDxzbmlwPgo+ID4gK3N0YXRpYyB2b2lkIHp4X3ZsX3Bs YW5lX2F0b21pY191cGRhdGUoc3RydWN0IGRybV9wbGFuZSAqcGxhbmUsCj4gPiArCQkJCSAgICAg IHN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKm9sZF9zdGF0ZSkKPiA+ICt7Cj4gPiArCXN0cnVjdCB6 eF9wbGFuZSAqenBsYW5lID0gdG9fenhfcGxhbmUocGxhbmUpOwo+ID4gKwlzdHJ1Y3QgZHJtX2Zy YW1lYnVmZmVyICpmYiA9IHBsYW5lLT5zdGF0ZS0+ZmI7Cj4gPiArCXN0cnVjdCBkcm1fZ2VtX2Nt YV9vYmplY3QgKmNtYV9vYmo7Cj4gPiArCXZvaWQgX19pb21lbSAqbGF5ZXIgPSB6cGxhbmUtPmxh eWVyOwo+ID4gKwl2b2lkIF9faW9tZW0gKmhic2MgPSB6cGxhbmUtPmhic2M7Cj4gPiArCXZvaWQg X19pb21lbSAqcGFkZHJfcmVnOwo+ID4gKwlkbWFfYWRkcl90IHBhZGRyOwo+ID4gKwl1MzIgc3Jj X3gsIHNyY195LCBzcmNfdywgc3JjX2g7Cj4gPiArCXUzMiBkc3RfeCwgZHN0X3ksIGRzdF93LCBk c3RfaDsKPiA+ICsJdWludDMyX3QgZm9ybWF0Owo+ID4gKwl1MzIgZm10Owo+ID4gKwlpbnQgbnVt X3BsYW5lczsKPiA+ICsJaW50IGk7Cj4gPiArCj4gPiArCWlmICghZmIpCj4gPiArCQlyZXR1cm47 Cj4gPiArCj4gPiArCWZvcm1hdCA9IGZiLT5waXhlbF9mb3JtYXQ7Cj4gPiArCj4gPiArCXNyY194 ID0gcGxhbmUtPnN0YXRlLT5zcmNfeCA+PiAxNjsKPiA+ICsJc3JjX3kgPSBwbGFuZS0+c3RhdGUt PnNyY195ID4+IDE2Owo+ID4gKwlzcmNfdyA9IHBsYW5lLT5zdGF0ZS0+c3JjX3cgPj4gMTY7Cj4g PiArCXNyY19oID0gcGxhbmUtPnN0YXRlLT5zcmNfaCA+PiAxNjsKPiA+ICsKPiA+ICsJZHN0X3gg PSBwbGFuZS0+c3RhdGUtPmNydGNfeDsKPiA+ICsJZHN0X3kgPSBwbGFuZS0+c3RhdGUtPmNydGNf eTsKPiA+ICsJZHN0X3cgPSBwbGFuZS0+c3RhdGUtPmNydGNfdzsKPiA+ICsJZHN0X2ggPSBwbGFu ZS0+c3RhdGUtPmNydGNfaDsKPiAKPiBUaGlzIHNob3VscyB1c2UgdGhlIGNsaXBwZWQgY29vcmRp YW50ZXMuCgpUaGFua3MgZm9yIHNwb3R0aW5nIHRoaXMuICBJIHdpbGwgZml4IGl0IGluIHYyLgoK U2hhd24KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==