From mboxrd@z Thu Jan  1 00:00:00 1970
Reply-To: kernel-hardening@lists.openwall.com
Date: Tue, 20 Dec 2016 16:52:21 +0100
From: Peter Zijlstra <peterz@infradead.org>
Message-ID: <20161220155221.GA5680@worktop>
References: <20161207135241.GI3107@twins.programming.kicks-ass.net>
 <2236FBA76BA1254E88B949DDB74E612B41C216AE@IRSMSX102.ger.corp.intel.com>
 <20161216140158.GS3107@twins.programming.kicks-ass.net>
 <2236FBA76BA1254E88B949DDB74E612B41C220DD@IRSMSX102.ger.corp.intel.com>
 <20161219101243.GB3107@twins.programming.kicks-ass.net>
 <2236FBA76BA1254E88B949DDB74E612B41C22713@IRSMSX102.ger.corp.intel.com>
 <20161220094152.GK3124@twins.programming.kicks-ass.net>
 <1482231302.28665.56.camel@cs-046.org.aalto.fi>
 <20161220131345.GM3124@twins.programming.kicks-ass.net>
 <1482247208.28665.121.camel@cs-046.org.aalto.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1482247208.28665.121.camel@cs-046.org.aalto.fi>
Subject: [kernel-hardening] Re: Conversion from atomic_t to refcount_t: summary of issues
To: Liljestrand Hans <ishkamiel@gmail.com>
Cc: "Reshetova, Elena" <elena.reshetova@intel.com>, "kernel-hardening@lists.openwall.com" <kernel-hardening@lists.openwall.com>, Greg KH <gregkh@linuxfoundation.org>, Kees Cook <keescook@chromium.org>, "will.deacon@arm.com" <will.deacon@arm.com>, Boqun Feng <boqun.feng@gmail.com>, David Windsor <dwindsor@gmail.com>, "aik@ozlabs.ru" <aik@ozlabs.ru>, "david@gibson.dropbear.id.au" <david@gibson.dropbear.id.au>
List-ID: <kernel-hardening.lists.openwall.com>

On Tue, Dec 20, 2016 at 05:20:08PM +0200, Liljestrand Hans wrote:
> > 
> > Didn't look at the rest, but going by the above blindly converting to
> > refcount_t without prior cleanups isn't a good idea.
> 
> Yes, I agree. Do you propose we just leave the weirder cases as
> atmoic_t, or should we try to incorporate needed cleanup in this initial
> patchset?
> 

Yes, I would leave them be for now. I imagine all the 'easy' ones is
still a giant pile of patches.