All of lore.kernel.org
 help / color / mirror / Atom feed
From: Samuel Thibault <samuel.thibault@gnu.org>
To: qemu-devel@nongnu.org
Cc: famz@redhat.com, stefanha@redhat.com, jan.kiszka@siemens.com
Subject: Re: [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks
Date: Wed, 21 Dec 2016 00:21:55 +0100	[thread overview]
Message-ID: <20161220232155.GS3258@var.home> (raw)
In-Reply-To: <148227574230.73.12239976842886455682@790289a7ca88>

no-reply@patchew.org, on Tue 20 Dec 2016 15:15:43 -0800, wrote:
> Your series seems to have some coding style problems. See output below for
> more information:


> ERROR: suspect code indent for conditional statements (10, 14)
> #90: FILE: slirp/tftp.c:393:
> +          if (blksize > 0) {
> +              spt->block_size = MIN(blksize, TFTP_BLOCKSIZE_MAX);

This is a false positive.

Samuel

  reply	other threads:[~2016-12-20 23:22 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-20 23:07 [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks Samuel Thibault
2016-12-20 23:07 ` [Qemu-devel] [PULL 1/2] slirp, disas: Replace min/max with MIN/MAX macros Samuel Thibault
2016-12-20 23:07 ` [Qemu-devel] [PULL 2/2] slirp: support dynamic block size for TFTP transfers Samuel Thibault
2016-12-20 23:15 ` [Qemu-devel] [PULL 0/2] slirp updates: MIN/MAX, tftp dynamic blocks no-reply
2016-12-20 23:21   ` Samuel Thibault [this message]
2016-12-22 17:52 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161220232155.GS3258@var.home \
    --to=samuel.thibault@gnu.org \
    --cc=famz@redhat.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.