From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm/i915: Beef up the IPS vs. CRC workaround Date: Wed, 21 Dec 2016 11:39:45 +0200 Message-ID: <20161221093945.GE31595@intel.com> References: <20161221093105.19120-1-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id E3EFE6EF65 for ; Wed, 21 Dec 2016 09:39:48 +0000 (UTC) Content-Disposition: inline In-Reply-To: <20161221093105.19120-1-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Paulo Zanoni List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBEZWMgMjEsIDIwMTYgYXQgMTE6MzE6MDVBTSArMDIwMCwgdmlsbGUuc3lyamFsYUBs aW51eC5pbnRlbC5jb20gd3JvdGU6Cj4gRnJvbTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJq YWxhQGxpbnV4LmludGVsLmNvbT4KPiAKPiBPbmVzaG90IGRpc2FibGluZyBvZiBJUFMgd2hlbiBD UkMgY2FwdHVyaW5nIGlzIHN0YXJ0ZWQgaXMgaW5zdWZmaWNpZW50Lgo+IElQUyBtYXkgZ2V0IHJl LWVuYWJsZWQgYnkgYW55IHBsYW5lIHVwZGF0ZSwgYW5kIGhlbmNlIHRlc3RzIHRoYXQga2VlcAo+ IENSQyBjYXB0dXJpbmcgb24gYWNyb3NzIHBsYW5lIHVwZGF0ZXMgd2lsbCBzdGFydCB0byBzZWUg aW5jb25zaXN0ZW50Cj4gcmVzdWx0cyBhcyBzb29uIGFzIElQUyBraWNrcyBiYWNrIGluLiBBZGQg YSBuZXcga25vYiBpbnRvIHRoZSBjcnRjIHN0YXRlCj4gdG8gbWFrZSBzdXJlIElQUyBzdGF5cyBk aXNhYmxlZCBhcyBsb25nIGFzIENSQyBjYXB0dXJpbmcgaXMgZW5hYmxlZC4KPiAKPiBGb3JjaW5n IGEgbW9kZXNldCBpcyB0aGUgZWFzaWVzdCB3YXkgdG8gaGFuZGxlIHRoaXMgc2luY2UgdGhhdCdz IGFscmVhZHkKPiBob3cgd2UgZG8gdGhlIHBhbmVsIGZpdHRlciB3b3JrYXJvdW5kLiBJdCdzIGEg bGl0dGxlIGhlYXZ5IGhhbmRlZCBqdXN0Cj4gZm9yIElQUywgYnV0IHNlZWluZyBhcyB3ZSBtaWdo dCBhbHJlYWR5IGRvIHRoZSBwYW5lbCBmaXR0ZXIgd29ya2Fyb3VuZAo+IEkgdGhpbmsgaXQncyBi ZXR0ZXIgdG8gZm9sbG93IHRoYXQuIFdlIG1pZ3RoIHdhbnQgdG8gb3B0aW1pemUgYm90aCBjYXNl cwo+IGxhdGVyIGlmIHNvbWVvbmUgZ2V0cyB0b28gdXBzZXQgYnkgdGhlIGV4dHJhIGRlbGF5IGZy b20gdGhlIG1vZGVzZXQuCj4gCj4gQ2M6IFBhdWxvIFphbm9uaSA8cGF1bG8uci56YW5vbmlAaW50 ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+IFNp Z25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5j b20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyAgfCAgNSAr KystCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICAgfCAgMSArCj4gIGRy aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMgfCA0MyArKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLQo+ICAzIGZpbGVzIGNoYW5nZWQsIDI4IGluc2VydGlvbnMoKyks IDIxIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiBp bmRleCBlZjVkZGU1YWIxY2YuLjFjZTQ3OTYxNGY1MiAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dw dS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9kaXNwbGF5LmMKPiBAQCAtNzE4OSw2ICs3MTg5LDcgQEAgc3RhdGljIHZvaWQgaHN3X2Nv bXB1dGVfaXBzX2NvbmZpZyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YywKPiAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsKPiAgCj4gIAlwaXBlX2NvbmZp Zy0+aXBzX2VuYWJsZWQgPSBpOTE1LmVuYWJsZV9pcHMgJiYKPiArCQkhcGlwZV9jb25maWctPmlw c19mb3JjZV9kaXNhYmxlICYmCj4gIAkJaHN3X2NydGNfc3VwcG9ydHNfaXBzKGNydGMpICYmCj4g IAkJcGlwZV9jb25maWdfc3VwcG9ydHNfaXBzKGRldl9wcml2LCBwaXBlX2NvbmZpZyk7Cj4gIH0K PiBAQCAtMTI5NTgsNyArMTI5NTksNyBAQCBjbGVhcl9pbnRlbF9jcnRjX3N0YXRlKHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ICAJc3RydWN0IGludGVsX2NydGNfc2NhbGVy X3N0YXRlIHNjYWxlcl9zdGF0ZTsKPiAgCXN0cnVjdCBpbnRlbF9kcGxsX2h3X3N0YXRlIGRwbGxf aHdfc3RhdGU7Cj4gIAlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGwgKnNoYXJlZF9kcGxsOwo+IC0J Ym9vbCBmb3JjZV90aHJ1Owo+ICsJYm9vbCBmb3JjZV90aHJ1LCBpcHNfZm9yY2VfZGlzYWJsZTsK PiAgCj4gIAkvKiBGSVhNRTogYmVmb3JlIHRoZSBzd2l0Y2ggdG8gYXRvbWljIHN0YXJ0ZWQsIGEg bmV3IHBpcGVfY29uZmlnIHdhcwo+ICAJICoga3phbGxvYydkLiBDb2RlIHRoYXQgZGVwZW5kcyBv biBhbnkgZmllbGQgYmVpbmcgemVybyBzaG91bGQgYmUKPiBAQCAtMTI5NzAsNiArMTI5NzEsNyBA QCBjbGVhcl9pbnRlbF9jcnRjX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0 YXRlKQo+ICAJc2hhcmVkX2RwbGwgPSBjcnRjX3N0YXRlLT5zaGFyZWRfZHBsbDsKPiAgCWRwbGxf aHdfc3RhdGUgPSBjcnRjX3N0YXRlLT5kcGxsX2h3X3N0YXRlOwo+ICAJZm9yY2VfdGhydSA9IGNy dGNfc3RhdGUtPnBjaF9wZml0LmZvcmNlX3RocnU7Cj4gKwlpcHNfZm9yY2VfZGlzYWJsZSA9IGNy dGNfc3RhdGUtPmlwc19mb3JjZV9kaXNhYmxlOwo+ICAKPiAgCW1lbXNldChjcnRjX3N0YXRlLCAw LCBzaXplb2YgKmNydGNfc3RhdGUpOwo+ICAKPiBAQCAtMTI5NzgsNiArMTI5ODAsNyBAQCBjbGVh cl9pbnRlbF9jcnRjX3N0YXRlKHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlKQo+ ICAJY3J0Y19zdGF0ZS0+c2hhcmVkX2RwbGwgPSBzaGFyZWRfZHBsbDsKPiAgCWNydGNfc3RhdGUt PmRwbGxfaHdfc3RhdGUgPSBkcGxsX2h3X3N0YXRlOwo+ICAJY3J0Y19zdGF0ZS0+cGNoX3BmaXQu Zm9yY2VfdGhydSA9IGZvcmNlX3RocnU7Cj4gKwljcnRjX3N0YXRlLT5pcHNfZm9yY2VfZGlzYWJs ZSA9IGlwc19mb3JjZV9kaXNhYmxlOwo+ICB9Cj4gIAo+ICBzdGF0aWMgaW50Cj4gZGlmZiAtLWdp dCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCAwMjVlNGM4YjNlNjMuLmNhZGJhOWI5MmNjOSAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gQEAgLTY1MSw2ICs2NTEsNyBAQCBzdHJ1Y3QgaW50 ZWxfY3J0Y19zdGF0ZSB7Cj4gIAlzdHJ1Y3QgaW50ZWxfbGlua19tX24gZmRpX21fbjsKPiAgCj4g IAlib29sIGlwc19lbmFibGVkOwo+ICsJYm9vbCBpcHNfZm9yY2VfZGlzYWJsZTsKPiAgCj4gIAli b29sIGVuYWJsZV9mYmM7Cj4gIAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF9waXBlX2NyYy5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9jcmMuYwo+ IGluZGV4IGVmMGMwZTE5NTE2NC4uNzA4Y2YxZDQxOWQ0IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9waXBlX2NyYy5jCj4gQEAgLTU0Nyw4ICs1NDcsOCBAQCBzdGF0aWMgaW50IGlsa19w aXBlX2NyY19jdGxfcmVnKGVudW0gaW50ZWxfcGlwZV9jcmNfc291cmNlICpzb3VyY2UsCj4gIAly ZXR1cm4gMDsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaHN3X3RyYW5zX2VkcF9waXBlX0FfY3Jj X3dhKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQkJCQlib29sIGVuYWJs ZSkKPiArc3RhdGljIHZvaWQgaHN3X3BpcGVfQV9jcmNfd2Eoc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmRldl9wcml2LAo+ICsJCQkgICAgICBib29sIGVuYWJsZSkKPiAgewo+ICAJc3RydWN0IGRy bV9kZXZpY2UgKmRldiA9ICZkZXZfcHJpdi0+ZHJtOwo+ICAJc3RydWN0IGludGVsX2NydGMgKmNy dGMgPSBpbnRlbF9nZXRfY3J0Y19mb3JfcGlwZShkZXZfcHJpdiwgUElQRV9BKTsKPiBAQCAtNTcw LDExICs1NzAsMjMgQEAgc3RhdGljIHZvaWQgaHN3X3RyYW5zX2VkcF9waXBlX0FfY3JjX3dhKHN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlnb3RvIG91dDsKPiAgCX0KPiAg Cj4gLQlwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZm9yY2VfdGhydSA9IGVuYWJsZTsKPiAtCWlmIChw aXBlX2NvbmZpZy0+Y3B1X3RyYW5zY29kZXIgPT0gVFJBTlNDT0RFUl9FRFAgJiYKPiAtCSAgICBw aXBlX2NvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZCAhPSBlbmFibGUpCj4gKwkvKgo+ICsJICogV2hl biBJUFMgZ2V0cyBlbmFibGVkLCB0aGUgcGlwZSBDUkMgY2hhbmdlcy4gU2luY2UgSVBTIGdldHMK PiArCSAqIGVuYWJsZWQgYW5kIGRpc2FibGVkIGR5bmFtaWNhbGx5IGJhc2VkIG9uIHBhY2thZ2Ug QyBzdGF0ZXMsCj4gKwkgKiB1c2VyIHNwYWNlIGNhbid0IG1ha2UgcmVsaWFibGUgdXNlIG9mIHRo ZSBDUkNzLCBzbyBsZXQncyBqdXN0Cj4gKwkgKiBjb21wbGV0ZWx5IGRpc2FibGUgaXQuCj4gKwkg Ki8KPiArCXBpcGVfY29uZmlnLT5pcHNfZm9yY2VfZGlzYWJsZSA9IGVuYWJsZTsKPiArCWlmIChw aXBlX2NvbmZpZy0+aXBzX2ZvcmNlX2Rpc2FibGUgIT0gZW5hYmxlKQoKQW5kIG5hdHVyYWxseSBJ IHR5cG9lZCB0aGF0LiBXaGF0IEkgcmVhbGx5IHdhbnRlZCB3YXM6CglpZiAocGlwZV9jb25maWct Pmlwc19lbmFibGVkID09IGVuYWJsZSkKCj4gIAkJcGlwZV9jb25maWctPmJhc2UuY29ubmVjdG9y c19jaGFuZ2VkID0gdHJ1ZTsKPiAgCj4gKwlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpIHsKPiAr CQlwaXBlX2NvbmZpZy0+cGNoX3BmaXQuZm9yY2VfdGhydSA9IGVuYWJsZTsKPiArCQlpZiAocGlw ZV9jb25maWctPmNwdV90cmFuc2NvZGVyID09IFRSQU5TQ09ERVJfRURQICYmCj4gKwkJICAgIHBp cGVfY29uZmlnLT5wY2hfcGZpdC5lbmFibGVkICE9IGVuYWJsZSkKPiArCQkJcGlwZV9jb25maWct PmJhc2UuY29ubmVjdG9yc19jaGFuZ2VkID0gdHJ1ZTsKPiArCX0KPiArCj4gIAlyZXQgPSBkcm1f YXRvbWljX2NvbW1pdChzdGF0ZSk7Cj4gIG91dDoKPiAgCVdBUk4ocmV0LCAiVG9nZ2xpbmcgd29y a2Fyb3VuZCB0byAlaSByZXR1cm5zICVpXG4iLCBlbmFibGUsIHJldCk7Cj4gQEAgLTU5OCw4ICs2 MTAsOSBAQCBzdGF0aWMgaW50IGl2Yl9waXBlX2NyY19jdGxfcmVnKHN0cnVjdCBkcm1faTkxNV9w cml2YXRlICpkZXZfcHJpdiwKPiAgCQkqdmFsID0gUElQRV9DUkNfRU5BQkxFIHwgUElQRV9DUkNf U09VUkNFX1NQUklURV9JVkI7Cj4gIAkJYnJlYWs7Cj4gIAljYXNlIElOVEVMX1BJUEVfQ1JDX1NP VVJDRV9QRjoKPiAtCQlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikgJiYgcGlwZSA9PSBQSVBFX0Ep Cj4gLQkJCWhzd190cmFuc19lZHBfcGlwZV9BX2NyY193YShkZXZfcHJpdiwgdHJ1ZSk7Cj4gKwkJ aWYgKChJU19IQVNXRUxMKGRldl9wcml2KSB8fAo+ICsJCSAgICAgSVNfQlJPQURXRUxMKGRldl9w cml2KSkgJiYgcGlwZSA9PSBQSVBFX0EpCj4gKwkJCWhzd19waXBlX0FfY3JjX3dhKGRldl9wcml2 LCB0cnVlKTsKPiAgCj4gIAkJKnZhbCA9IFBJUEVfQ1JDX0VOQUJMRSB8IFBJUEVfQ1JDX1NPVVJD RV9QRl9JVkI7Cj4gIAkJYnJlYWs7Cj4gQEAgLTYxOCw3ICs2MzEsNiBAQCBzdGF0aWMgaW50IHBp cGVfY3JjX3NldF9zb3VyY2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJ CQkgICAgICAgZW51bSBpbnRlbF9waXBlX2NyY19zb3VyY2Ugc291cmNlKQo+ICB7Cj4gIAlzdHJ1 Y3QgaW50ZWxfcGlwZV9jcmMgKnBpcGVfY3JjID0gJmRldl9wcml2LT5waXBlX2NyY1twaXBlXTsK PiAtCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjID0gaW50ZWxfZ2V0X2NydGNfZm9yX3BpcGUoZGV2 X3ByaXYsIHBpcGUpOwo+ICAJZW51bSBpbnRlbF9kaXNwbGF5X3Bvd2VyX2RvbWFpbiBwb3dlcl9k b21haW47Cj4gIAl1MzIgdmFsID0gMDsgLyogc2h1dCB1cCBnY2MgKi8KPiAgCWludCByZXQ7Cj4g QEAgLTY2NSwxNCArNjc3LDYgQEAgc3RhdGljIGludCBwaXBlX2NyY19zZXRfc291cmNlKHN0cnVj dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJZ290byBvdXQ7Cj4gIAkJfQo+ICAK PiAtCQkvKgo+IC0JCSAqIFdoZW4gSVBTIGdldHMgZW5hYmxlZCwgdGhlIHBpcGUgQ1JDIGNoYW5n ZXMuIFNpbmNlIElQUyBnZXRzCj4gLQkJICogZW5hYmxlZCBhbmQgZGlzYWJsZWQgZHluYW1pY2Fs bHkgYmFzZWQgb24gcGFja2FnZSBDIHN0YXRlcywKPiAtCQkgKiB1c2VyIHNwYWNlIGNhbid0IG1h a2UgcmVsaWFibGUgdXNlIG9mIHRoZSBDUkNzLCBzbyBsZXQncyBqdXN0Cj4gLQkJICogY29tcGxl dGVseSBkaXNhYmxlIGl0Lgo+IC0JCSAqLwo+IC0JCWhzd19kaXNhYmxlX2lwcyhjcnRjKTsKPiAt Cj4gIAkJc3Bpbl9sb2NrX2lycSgmcGlwZV9jcmMtPmxvY2spOwo+ICAJCWtmcmVlKHBpcGVfY3Jj LT5lbnRyaWVzKTsKPiAgCQlwaXBlX2NyYy0+ZW50cmllcyA9IGVudHJpZXM7Cj4gQEAgLTcxMywx MCArNzE3LDkgQEAgc3RhdGljIGludCBwaXBlX2NyY19zZXRfc291cmNlKHN0cnVjdCBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQkJZzR4X3VuZG9fcGlwZV9zY3JhbWJsZV9yZXNldChk ZXZfcHJpdiwgcGlwZSk7Cj4gIAkJZWxzZSBpZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwg SVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpCj4gIAkJCXZsdl91bmRvX3BpcGVfc2NyYW1ibGVfcmVz ZXQoZGV2X3ByaXYsIHBpcGUpOwo+IC0JCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpICYm IHBpcGUgPT0gUElQRV9BKQo+IC0JCQloc3dfdHJhbnNfZWRwX3BpcGVfQV9jcmNfd2EoZGV2X3By aXYsIGZhbHNlKTsKPiAtCj4gLQkJaHN3X2VuYWJsZV9pcHMoY3J0Yyk7Cj4gKwkJZWxzZSBpZiAo KElTX0hBU1dFTEwoZGV2X3ByaXYpIHx8Cj4gKwkJCSAgSVNfQlJPQURXRUxMKGRldl9wcml2KSkg JiYgcGlwZSA9PSBQSVBFX0EpCj4gKwkJCWhzd19waXBlX0FfY3JjX3dhKGRldl9wcml2LCBmYWxz ZSk7Cj4gIAl9Cj4gIAo+ICAJcmV0ID0gMDsKPiAtLSAKPiAyLjEwLjIKCi0tIApWaWxsZSBTeXJq w6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVs LWdmeAo=