Re: [PATCH 2/4] init/FreeBSD: remove xendriverdomain_precmd

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Dec 19, 2016 at 03:02:02PM +0000, Roger Pau Monne wrote:
> ...because it's empty. While there also rename xendriverdomain_startcmd to
> xendriverdomain_start in order to match the nomenclature of the file.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
> 
> diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> index 3917de2..c71871c 100644
> --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> @@ -13,19 +13,13 @@ LD_LIBRARY_PATH="${libdir}"
>  export LD_LIBRARY_PATH
>  
>  name="xendriverdomain"
> -start_precmd="xendriverdomain_precmd"
>  start_cmd="xendriverdomain_startcmd"
                              ^^^^^^^^
                              You missed this.

otherwise:

Acked-by: Wei Liu <wei.liu2@citrix.com>

>  stop_cmd="xendriverdomain_stop"
>  extra_commands=""
>  
>  XLDEVD_PIDFILE="@XEN_RUN_DIR@/xldevd.pid"
>  
> -xendriverdomain_precmd()
> -{
> -	:
> -}
> -
> -xendriverdomain_startcmd()
> +xendriverdomain_start()
>  {
>  	printf "Starting xenservices: xl devd."
>  
> -- 
> 2.10.1 (Apple Git-78)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel