From mboxrd@z Thu Jan 1 00:00:00 1970 From: andrew@lunn.ch (Andrew Lunn) Date: Wed, 21 Dec 2016 16:22:30 +0100 Subject: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports In-Reply-To: <20161221132519.bkkqyfk3beow7nc5@pengutronix.de> References: <1482131877-6097-3-git-send-email-andrew.smirnov@gmail.com> <1482325125-15725-1-git-send-email-nikita.yoush@cogentembedded.com> <20161221132519.bkkqyfk3beow7nc5@pengutronix.de> Message-ID: <20161221152230.GK30952@lunn.ch> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Dec 21, 2016 at 02:25:19PM +0100, Uwe Kleine-K?nig wrote: > On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > > are not limiting link's speed and the ports will be configured to their > > > maximux speed as a default) > > > > > > Suggested-by: Andrew Lunn > > > Signed-off-by: Andrey Smirnov > > > > With this patch, ports connected to revB's second switch stop working. > > This is probably because without a fixed-link node the phy-mode setting > isn't applied by the driver. Yep, bad suggestion from me. If the phy-mode was not needed, then you can drop the fixed-link. With the phy-mode, you also need the fixed link. Sorry for the wasted time, Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports Date: Wed, 21 Dec 2016 16:22:30 +0100 Message-ID: <20161221152230.GK30952@lunn.ch> References: <1482131877-6097-3-git-send-email-andrew.smirnov@gmail.com> <1482325125-15725-1-git-send-email-nikita.yoush@cogentembedded.com> <20161221132519.bkkqyfk3beow7nc5@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: <20161221132519.bkkqyfk3beow7nc5-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Nikita Yushchenko , Andrey Smirnov , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Mark Rutland , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Vivien Didelot , Russell King , Stefan Agner , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Rob Herring , Sascha Hauer , Shawn Guo , cphealy-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org List-Id: devicetree@vger.kernel.org On Wed, Dec 21, 2016 at 02:25:19PM +0100, Uwe Kleine-König wrote: > On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > > are not limiting link's speed and the ports will be configured to their > > > maximux speed as a default) > > > > > > Suggested-by: Andrew Lunn > > > Signed-off-by: Andrey Smirnov > > > > With this patch, ports connected to revB's second switch stop working. > > This is probably because without a fixed-link node the phy-mode setting > isn't applied by the driver. Yep, bad suggestion from me. If the phy-mode was not needed, then you can drop the fixed-link. With the phy-mode, you also need the fixed link. Sorry for the wasted time, Andrew -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758340AbcLUPWr (ORCPT ); Wed, 21 Dec 2016 10:22:47 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:34084 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752675AbcLUPWo (ORCPT ); Wed, 21 Dec 2016 10:22:44 -0500 Date: Wed, 21 Dec 2016 16:22:30 +0100 From: Andrew Lunn To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Nikita Yushchenko , Andrey Smirnov , linux-arm-kernel@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Vivien Didelot , Russell King , Stefan Agner , linux-kernel@vger.kernel.org, Rob Herring , Sascha Hauer , Shawn Guo , cphealy@gmail.com Subject: Re: [v4, 3/3] ARM: dts: vf610-zii-dev-rev-b: Remove 'fixed-link' from DSA ports Message-ID: <20161221152230.GK30952@lunn.ch> References: <1482131877-6097-3-git-send-email-andrew.smirnov@gmail.com> <1482325125-15725-1-git-send-email-nikita.yoush@cogentembedded.com> <20161221132519.bkkqyfk3beow7nc5@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161221132519.bkkqyfk3beow7nc5@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2016 at 02:25:19PM +0100, Uwe Kleine-König wrote: > On Wed, Dec 21, 2016 at 03:58:45PM +0300, Nikita Yushchenko wrote: > > > Remove 'fixed-link' nodes from DSA ports since they are not needed (they > > > are not limiting link's speed and the ports will be configured to their > > > maximux speed as a default) > > > > > > Suggested-by: Andrew Lunn > > > Signed-off-by: Andrey Smirnov > > > > With this patch, ports connected to revB's second switch stop working. > > This is probably because without a fixed-link node the phy-mode setting > isn't applied by the driver. Yep, bad suggestion from me. If the phy-mode was not needed, then you can drop the fixed-link. With the phy-mode, you also need the fixed link. Sorry for the wasted time, Andrew