From: Sam Ravnborg <sam@ravnborg.org>
To: sparclinux@vger.kernel.org
Subject: Re: [PATCH v2] sparc64: shut down to OBP correctly
Date: Wed, 21 Dec 2016 18:10:37 +0000 [thread overview]
Message-ID: <20161221181037.GA3311@ravnborg.org> (raw)
In-Reply-To: <1482340634-65842-1-git-send-email-larry.bassel@oracle.com>
Hi Larry.
Little nitpick...
> args[2] = 0;
> p1275_cmd_direct(args);
> - goto again; /* PROM is out to get me -DaveM */
> + while (1);
If you write this like:
for (;;)
/* forever */;
It is much more obvious that this is supposed to loop forever.
As it is now it more looks like an oversight.
Sam
prev parent reply other threads:[~2016-12-21 18:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 17:17 [PATCH v2] sparc64: shut down to OBP correctly Larry Bassel
2016-12-21 18:10 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221181037.GA3311@ravnborg.org \
--to=sam@ravnborg.org \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.