From: Matt Fleming <matt@codeblueprint.co.uk>
To: Petr Oros <poros@redhat.com>
Cc: ard.biesheuvel@linaro.org, tglx@linutronix.de, mingo@redhat.com,
hpa@zytor.com, x86@kernel.org, linux-efi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/efi Fix regression in efi_arch_mem_reserve
Date: Wed, 21 Dec 2016 22:30:54 +0000 [thread overview]
Message-ID: <20161221223054.GG2225@codeblueprint.co.uk> (raw)
In-Reply-To: <20161221131138.10512-1-poros@redhat.com>
On Wed, 21 Dec, at 02:11:38PM, Petr Oros wrote:
> Booting on EFI with ESRT table has been stop since commit:
> 8e80632 efi/esrt: Use efi_mem_reserve() and avoid a kmalloc()
>
> This is caused by this commit:
> 816e761 efi: Allow drivers to reserve boot services forever
>
> Problem is, that efi_memmap_insert need memory aligned
> on EFI_PAGE_SIZE. If memory not aligned, efi_memmap_insert
> just return and let efi.memmap in inconsistent state.
> This breaking boot.
>
> Tested in my machine, which stop booting
> after upgrade to 4.9
>
> Signed-off-by: Petr Oros <poros@redhat.com>
> ---
> arch/x86/platform/efi/quirks.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Could you provide some more information? Why does efi_memmap_insert()
require this alignment? How does booting "break"? If you see an Oops,
please post it here.
next prev parent reply other threads:[~2016-12-21 22:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 13:11 [PATCH] x86/efi Fix regression in efi_arch_mem_reserve Petr Oros
2016-12-21 13:11 ` Petr Oros
2016-12-21 22:30 ` Matt Fleming [this message]
[not found] ` <20161221223054.GG2225-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2016-12-22 10:21 ` Petr Oros
2016-12-22 10:21 ` Petr Oros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221223054.GG2225@codeblueprint.co.uk \
--to=matt@codeblueprint.co.uk \
--cc=ard.biesheuvel@linaro.org \
--cc=hpa@zytor.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=poros@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.