From: Al Viro <viro@ZenIV.linux.org.uk>
To: Jon Maloy <jon.maloy@ericsson.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org,
parthasarathy.bhuvaragan@ericsson.com, ying.xue@windriver.com,
maloy@donjonn.com, tipc-discussion@lists.sourceforge.net
Subject: Re: [PATCH net 1/1] tipc: revert use of copy_from_iter_full()
Date: Thu, 22 Dec 2016 01:21:01 +0000 [thread overview]
Message-ID: <20161222012101.GF1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1482368497-7103-1-git-send-email-jon.maloy@ericsson.com>
On Wed, Dec 21, 2016 at 08:01:37PM -0500, Jon Maloy wrote:
> commit cbbd26b8b1a6 ("[iov_iter] new primitives - copy_from_iter_full()
> and friends") replaced calls to copy_from_iter() in the function
> tipc_msg_build(). This causes a an immediate crash as follows:
Very interesting.
> [ 1209.597076] BUG: unable to handle kernel NULL pointer dereference at 0000000000000008
> [ 1209.607025] IP: copy_from_iter_full+0x43/0x290
> [ 1209.689257] tipc_msg_build+0xe1/0x590 [tipc]
> [ 1209.691479] ? _raw_spin_unlock_bh+0x1e/0x20
> [ 1209.694641] ? tipc_node_find+0x30/0xa0 [tipc]
> [ 1209.696789] __tipc_sendmsg+0x189/0x480 [tipc]
> [ 1209.699017] ? remove_wait_queue+0x4d/0x60
> [ 1209.700354] tipc_connect+0x15f/0x1b0 [tipc]
> [ 1209.701684] SYSC_connect+0xd9/0x110
I don't believe that it's something tipc-specific; could you post an objdump
of copy_from_iter_full() in your kernel? That smells like a bug in there
and it really ought to be fixed...
next prev parent reply other threads:[~2016-12-22 2:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 1:01 [PATCH net 1/1] tipc: revert use of copy_from_iter_full() Jon Maloy
2016-12-22 1:21 ` Al Viro [this message]
2016-12-22 1:43 ` Al Viro
2016-12-22 2:47 ` Jon Maloy
2016-12-22 3:07 ` Al Viro
2016-12-22 12:57 ` Jon Maloy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222012101.GF1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=davem@davemloft.net \
--cc=jon.maloy@ericsson.com \
--cc=maloy@donjonn.com \
--cc=netdev@vger.kernel.org \
--cc=parthasarathy.bhuvaragan@ericsson.com \
--cc=tipc-discussion@lists.sourceforge.net \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.