From: Cyril Bur <cyrilbur@gmail.com>
To: openbmc@lists.ozlabs.org
Cc: millerjo@linux.vnet.ibm.com
Subject: [PATCH v2 0/5] LPC/MBOX work
Date: Thu, 22 Dec 2016 17:06:05 +1100 [thread overview]
Message-ID: <20161222060610.29695-1-cyrilbur@gmail.com> (raw)
Hi all,
Sending this v2 a little prematurely but it will be good to have some eyes on it.
I haven't been able to boot the host with this as there are quite a few caveats.
First of all hostboot expects the flash at a very specific place on the host LPC
bus per platform. This creates problems when a machine of a certain type has a
flash chip of a different size as to what it should have. This renders the UNMAP
ioctl() somewhat useless. We should be able to compensate for this in userspace,
which is good since I don't want any of these caveats worked around in the kernel.
I have had some troubles with regmap_write() but it is possible the bug has been
fixed. I will test in the coming days and confirm.
I have attempted to address all the review comments:
- Use of regmap
- Open counts to avoid opening by different processes
- Style fixes
- Move mbox to drivers/mailbox
- Extra descriptions
Notable exception that I haven't gotten around to but will happily do once we
get to a working state is preventing mutiple threads from writing mbox registers
at once
Thanks,
Cyril
Cyril Bur (5):
ARM: dts: aspeed: Reserve BMC ram for host to BMC communication
ARM: dts: aspeed: Put the lpc_ctrl under lpc_host node for regmap
ARM: dts: aspeed: Move mbox under lpc_host node
drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver
drivers/misc: Add aspeed ast2400/ast2500 lpc controlling driver
arch/arm/boot/dts/aspeed-bmc-opp-barreleye.dts | 6 +
arch/arm/boot/dts/aspeed-bmc-opp-firestone.dts | 6 +
arch/arm/boot/dts/aspeed-bmc-opp-garrison.dts | 6 +
arch/arm/boot/dts/aspeed-bmc-opp-palmetto.dts | 7 +
arch/arm/boot/dts/aspeed-g4.dtsi | 36 +++
drivers/mailbox/Kconfig | 9 +
drivers/mailbox/Makefile | 3 +
drivers/mailbox/aspeed-mbox.c | 354 +++++++++++++++++++++++++
drivers/misc/Kconfig | 9 +
drivers/misc/Makefile | 1 +
drivers/misc/aspeed-lpc-ctrl.c | 292 ++++++++++++++++++++
include/uapi/linux/aspeed-lpc-ctrl.h | 25 ++
include/uapi/linux/aspeed-mbox.h | 23 ++
13 files changed, 777 insertions(+)
create mode 100644 drivers/mailbox/aspeed-mbox.c
create mode 100644 drivers/misc/aspeed-lpc-ctrl.c
create mode 100644 include/uapi/linux/aspeed-lpc-ctrl.h
create mode 100644 include/uapi/linux/aspeed-mbox.h
--
2.11.0
next reply other threads:[~2016-12-22 6:06 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-22 6:06 Cyril Bur [this message]
2016-12-22 6:06 ` [PATCH v2 1/5] ARM: dts: aspeed: Reserve BMC ram for host to BMC communication Cyril Bur
2016-12-23 1:01 ` Andrew Jeffery
2016-12-23 7:50 ` Cyril Bur
2016-12-22 6:06 ` [PATCH v2 2/5] ARM: dts: aspeed: Put the lpc_ctrl under lpc_host node for regmap Cyril Bur
2016-12-22 6:06 ` [PATCH v2 3/5] ARM: dts: aspeed: Move mbox under lpc_host node Cyril Bur
2016-12-22 6:06 ` [PATCH v2 4/5] drivers/mailbox: Add aspeed ast2400/ast2500 mbox driver Cyril Bur
2016-12-23 2:42 ` Andrew Jeffery
2016-12-23 7:56 ` Cyril Bur
2017-01-03 1:24 ` Andrew Jeffery
2017-01-08 21:44 ` Benjamin Herrenschmidt
2017-01-08 23:54 ` Andrew Jeffery
2017-01-08 21:45 ` Benjamin Herrenschmidt
2017-01-09 22:09 ` Cyril Bur
2017-01-09 22:55 ` Andrew Jeffery
2017-01-09 23:18 ` Cyril Bur
2017-01-10 0:07 ` Cyril Bur
2017-01-10 0:10 ` Andrew Jeffery
2017-01-10 4:28 ` Benjamin Herrenschmidt
2017-01-10 4:36 ` Cyril Bur
2017-01-10 4:40 ` Benjamin Herrenschmidt
2017-01-08 21:39 ` Benjamin Herrenschmidt
2016-12-22 6:06 ` [PATCH v2 5/5] drivers/misc: Add aspeed ast2400/ast2500 lpc controlling driver Cyril Bur
2016-12-22 23:54 ` Cyril Bur
2016-12-23 2:43 ` Andrew Jeffery
2016-12-23 2:55 ` Andrew Jeffery
2016-12-23 8:04 ` Cyril Bur
2017-01-03 1:33 ` Andrew Jeffery
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161222060610.29695-1-cyrilbur@gmail.com \
--to=cyrilbur@gmail.com \
--cc=millerjo@linux.vnet.ibm.com \
--cc=openbmc@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.