From: Al Viro <viro@ZenIV.linux.org.uk>
To: kbuild test robot <fengguang.wu@intel.com>
Cc: kbuild-all@01.org, linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [vfs:for-linus 1/8] arch/x86/built-in.o:undefined reference to `compat_sys_io_setup'
Date: Fri, 23 Dec 2016 04:06:28 +0000 [thread overview]
Message-ID: <20161223040628.GI1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <201612231119.mDMIgPtQ%fengguang.wu@intel.com>
On Fri, Dec 23, 2016 at 11:25:22AM +0800, kbuild test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git for-linus
> head: d0375bfcdd0de588d9f8ee7ac9d2bc93c333e4fe
> commit: e46c3fc8ff9e7aa152ef078af7067d5391f4fe18 [1/8] move aio compat to fs/aio.c
> config: x86_64-randconfig-s2-12230841 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
> git checkout e46c3fc8ff9e7aa152ef078af7067d5391f4fe18
> # save the attached .config to linux build tree
> make ARCH=x86_64
What the...? Wait a sec, you have CONFIG_COMPAT, but not CONFIG_AIO in
there? What's missing there is
+cond_syscall(compat_sys_io_setup);
+cond_syscall(compat_sys_io_submit);
+cond_syscall(compat_sys_io_getevents);
in kernel/sys_ni.c
Lovely, that - previously mainline had built compat_sys_io_setup() et.al. on
configs without CONFIG_AIO, only to have it allocate a native iocb array,
carefully convert the 32bit ones into it, then call dummy do_io_submit()
which did nothing and returned 0. While 64bit task doing the same would
get -ENOSYS instead... Fixed and folded.
My apologies - I hadn't checked that config and missed that weirdness
completely.
prev parent reply other threads:[~2016-12-23 4:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-23 3:25 [vfs:for-linus 1/8] arch/x86/built-in.o:undefined reference to `compat_sys_io_setup' kbuild test robot
2016-12-23 4:06 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161223040628.GI1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=fengguang.wu@intel.com \
--cc=kbuild-all@01.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.