All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Christian Hemp <c.hemp@phytec.de>
Cc: barebox@lists.infradead.org
Subject: Re: [PATCH] mtd: nand_mxs: fix NAND error when change clk rate
Date: Fri, 23 Dec 2016 11:39:47 +0100	[thread overview]
Message-ID: <20161223103947.GA11937@ravnborg.org> (raw)
In-Reply-To: <1482356321-19996-1-git-send-email-c.hemp@phytec.de>

On Wed, Dec 21, 2016 at 10:38:41PM +0100, Christian Hemp wrote:
> The function "nand_enable_edo_mode" changed the NAND clk rate, without turning
> it off. In this case it is posible to get the following errors:
>     MXS NAND: Error sending command
>     MXS NAND: Error sending command
>     MXS NAND: DMA read error
> 
> This can be fixed if the NAND clk is disabled before we change the clk
> rate.
> 
> Tested with:
> nand: NAND device: Manufacturer ID: 0x2c, Chip ID: 0xdc (Micron
> MT29F4G08ABADAWP), 512MiB, page size: 2048, OOB size: 64
> 
> Signed-off-by: Christian Hemp <c.hemp@phytec.de>
Tested-by: Sam Ravnborg <sam@ravnborg.org>

We had it running over night - not a single DMA error.
Tested with 16 different targets in an ON/OFF test.
I do not have numbers for the ON/OFF cycles but it is more than 10 each.
Previously we had a high frequency of these.
And tonight there was none.

Christian - if we ever meet in person I owe you a beer!

	Sam

_______________________________________________
barebox mailing list
barebox@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/barebox

  parent reply	other threads:[~2016-12-23 10:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 21:38 [PATCH] mtd: nand_mxs: fix NAND error when change clk rate Christian Hemp
2016-12-21 22:29 ` Sam Ravnborg
2016-12-22  8:50   ` Christian Hemp
2016-12-22 17:55     ` Sam Ravnborg
2016-12-23 10:39 ` Sam Ravnborg [this message]
2016-12-27 17:07 ` Fabio Estevam
2017-01-09 10:21 ` Sascha Hauer
2017-08-21 16:26   ` Uwe Kleine-König
2017-08-21 16:31     ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161223103947.GA11937@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=barebox@lists.infradead.org \
    --cc=c.hemp@phytec.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.