From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:49380 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753429AbcLXAWV (ORCPT ); Fri, 23 Dec 2016 19:22:21 -0500 Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id uBO0Isss091017 for ; Fri, 23 Dec 2016 19:22:21 -0500 Received: from e38.co.us.ibm.com (e38.co.us.ibm.com [32.97.110.159]) by mx0a-001b2d01.pphosted.com with ESMTP id 27h70e5x5y-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 23 Dec 2016 19:22:20 -0500 Received: from localhost by e38.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Dec 2016 17:22:20 -0700 Date: Fri, 23 Dec 2016 16:22:17 -0800 From: "Paul E. McKenney" Subject: Re: [PATCH 0/3] Patches for recent updates Reply-To: paulmck@linux.vnet.ibm.com References: <729a5146-a533-0511-d3a0-88ca20a10106@gmail.com> <20161223185842.GB3742@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Message-Id: <20161224002217.GE3742@linux.vnet.ibm.com> Sender: perfbook-owner@vger.kernel.org List-ID: To: Akira Yokosawa Cc: perfbook@vger.kernel.org On Sat, Dec 24, 2016 at 08:56:27AM +0900, Akira Yokosawa wrote: > On 2016/12/23 10:58:42 -0800, Paul E. McKenney wrote: > > On Fri, Dec 23, 2016 at 05:07:17PM +0900, Akira Yokosawa wrote: > >> >From cbb7797d6b307850a280248589bc09b8852e8a68 Mon Sep 17 00:00:00 2001 > >> From: Akira Yokosawa > >> Date: Fri, 23 Dec 2016 16:46:06 +0900 > >> Subject: [PATCH 0/3] Patches for recent updates > >> > >> Hi Paul, > >> > >> This short patch set consists of fixes to recent updates in > >> advsync/memorybarriers. > >> > >> I'm not sure what is your preference of quotation of short variable > >> names and keywords. In the 1st patch, I chose the form of ~~\co{a}''. > >> If you prefer other one, please let me know. > >> > >> Ya, I know a variety of styles are mixed-used in perfbook, > >> reflecting various original publications... > > > > My current rule is that an identifier can be mistaken for an English > > word or letter of the alphabet, then it should be in double quotation > > marks and under \co{}, consistent with your changes. However, something > > like "rcu_node" cannot reasonably be mistaken for English, so it only > > needs \co{}. > > > > Thoughts? > > So, the cause of potential confusion here is the use of variable name "a", > isn't it? If "a" were not there, other variable names b, c, q, x, and y would > not need quotation marks, I suppose. > "if", "then", and "else" still need quotation. > > Hmm? Indeed, "a" is the main cause of confusion that leads me to believe that single-letter variable names need quotes. Unless the variable names are capitalized, in which case "I" is the bad boy. ;-) Thanx, Paul > >> But at least within a (sub)section, it would be better to keep > >> consistency. > > > > Applied and pushed, thank you! > > > > Thanx, Paul > > > >> Thanks, Akira > >> -- > >> Akira Yokosawa (3): > >> advsync/memorybarriers: Use consistent quotation marks > >> advsync/memorybarriers: Fix typo (READ_ONCE -> WRITE_ONCE) > >> advsync/memorybarriers: Fix trivial typo > >> > >> advsync/memorybarriers.tex | 30 +++++++++++++++--------------- > >> 1 file changed, 15 insertions(+), 15 deletions(-) > >> > >> -- > >> 2.7.4 > >> > > > > >