From: Al Viro <viro@ZenIV.linux.org.uk>
To: Scott Matheina <scott@matheina.com>
Cc: linux-kernel@vger.kernel.org,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-iio@vger.kernel.org, devel@driverdev.osuosl.org
Subject: Re: [PATCHv4 2/8] Fixed variables not being consistently lower case
Date: Sun, 25 Dec 2016 20:14:09 +0000 [thread overview]
Message-ID: <20161225201409.GL1555@ZenIV.linux.org.uk> (raw)
In-Reply-To: <1482694902-7400-3-git-send-email-scott@matheina.com>
On Sun, Dec 25, 2016 at 01:41:06PM -0600, Scott Matheina wrote:
> Across the file, variables were sometimes upper case, some times
> lower case, this fix addresses a few of the instances with this
> inconsistency.
NAK. Go learn C and don't come back until you've done that. If somebody
has told you that you can contribute without knowing the language, they'd
lied - you really can't. And I would *STRONGLY* recommend to stay away
from drivers/staging while you are learning C - it's like trying to use
a public restroom wall as a sex-ed textbook.
While we are at it, it might be a good idea to check if the kernel
builds after your changes and see what errors are produced.
next prev parent reply other threads:[~2016-12-25 20:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-25 19:41 [PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac Scott Matheina
2016-12-25 19:41 ` [PATCHv4 1/8] fixed long description text exceeding 80 characters Scott Matheina
2016-12-25 19:41 ` [PATCHv4 2/8] Fixed variables not being consistently lower case Scott Matheina
2016-12-25 20:14 ` Al Viro [this message]
2016-12-25 22:34 ` Jonathan Cameron
2016-12-25 22:34 ` Jonathan Cameron
2016-12-26 0:13 ` Al Viro
2016-12-25 19:41 ` [PATCHv4 3/8] Fix camel case issues Scott Matheina
2016-12-25 19:41 ` [PATCHv4 4/8] Fix braces not present on all arms of if else statement Scott Matheina
2016-12-25 19:41 ` [PATCHv4 5/8] Remove line after closing braces Scott Matheina
2016-12-25 19:41 ` [PATCHv4 7/8] Changed code to align with coding style of using octat Scott Matheina
-- strict thread matches above, loose matches on Subject: below --
2016-12-25 19:56 [PATCHv4 0/8] Checkpatch fixes to driver/staging/iio/addac Scott Matheina
2016-12-25 19:56 ` [PATCHv4 2/8] Fixed variables not being consistently lower case Scott Matheina
2016-12-25 20:31 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161225201409.GL1555@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=Michael.Hennerich@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
--cc=scott@matheina.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.