From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH v2 4/7] net/virtio_user: abstract virtio user
	backend ops
Date: Mon, 26 Dec 2016 14:41:14 +0800
Message-ID: <20161226064114.GC19288@yliu-dev.sh.intel.com>
References: <1480689075-66977-1-git-send-email-jianfeng.tan@intel.com>
 <1482477266-39199-1-git-send-email-jianfeng.tan@intel.com>
 <1482477266-39199-5-git-send-email-jianfeng.tan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, ferruh.yigit@intel.com, cunming.liang@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id D811B2B86
 for <dev@dpdk.org>; Mon, 26 Dec 2016 07:39:29 +0100 (CET)
Content-Disposition: inline
In-Reply-To: <1482477266-39199-5-git-send-email-jianfeng.tan@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Fri, Dec 23, 2016 at 07:14:23AM +0000, Jianfeng Tan wrote:
> +typedef int (*vhost_setup_t)(struct virtio_user_dev *dev);
> +typedef int (*vhost_send_request_t)(struct virtio_user_dev *dev,
> +				    enum vhost_user_request req,
> +				    void *arg);
> +typedef int (*vhost_enable_qp_t)(struct virtio_user_dev *dev,
> +				 uint16_t pair_idx,
> +				 int enable);

I will not bother to define new types if they are just gonna be used once.
No strong perference here, just a suggestion.

...
> diff --git a/drivers/net/virtio/virtio_user/virtio_user_dev.h b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> index 28fc788..503a496 100644
> --- a/drivers/net/virtio/virtio_user/virtio_user_dev.h
> +++ b/drivers/net/virtio/virtio_user/virtio_user_dev.h
> @@ -37,9 +37,15 @@
>  #include <limits.h>
>  #include "../virtio_pci.h"
>  #include "../virtio_ring.h"
> +#include "vhost.h"
>  
>  struct virtio_user_dev {
> +	/* for vhost_user backend */
>  	int		vhostfd;
> +
> +	/* for vhost_kernel backend */
> +
> +	/* for both vhost_user and vhost_kernel */

By far (till this patch), vhost_kernel is not introduced at all, that I
will not mention it here. That said, I will leave this change to the patch
that actually enables vhost-kernel.

	--yliu