Re: [PATCH 1/1 v2] dtc: fdtdump: check fdt if not in scanning mode

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

On Mon, Dec 26, 2016 at 06:24:20PM +1300, Simon Glass wrote:
> On 22 December 2016 at 12:59, Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org> wrote:
> > Running fdtdump without scan mode for an invalid file often
> > results in a segmentation fault because the fdt header is
> > not checked.
> >
> > With the patch the header is checked both in scanning as
> > well as in non-scanning mode.
> >
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk-Mmb7MZpHnFY@public.gmane.org>
> > ---
> >
> > v2:
> >         Refactor header check as separate function.
> >
> >  fdtdump.c | 27 +++++++++++++++++++--------
> >  1 file changed, 19 insertions(+), 8 deletions(-)
> 
> Reviewed-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> 
> nit: I don't think the function needs to be marked 'inline'. It is not
> time-critical.

Ah, yes.  In fact, the 'inline' keyword should generally be avoided
except in header files.  The compiler nearly always has better
information than you do about whether it's a good idea to inline a
function or not.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]