From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tony Lindgren Subject: Re: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string Date: Tue, 27 Dec 2016 09:40:18 -0800 Message-ID: <20161227174018.GT4920@atomide.com> References: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Maninder Singh Cc: Vaneet Narang , paul@pwsan.com, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, ajeet.y@samsung.com, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, pankaj.m@samsung.com List-Id: linux-omap@vger.kernel.org * Maninder Singh [161207 20:16]: > Issue caught with static analysis tool: > "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)" > > Use strlcpy _includes_ the NUL terminator, and strlcat() which ensures > that it won't overflow the buffer. Applying into omap-for-v4.10/fixes thanks. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Tue, 27 Dec 2016 09:40:18 -0800 Subject: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string In-Reply-To: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com> References: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com> Message-ID: <20161227174018.GT4920@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Maninder Singh [161207 20:16]: > Issue caught with static analysis tool: > "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)" > > Use strlcpy _includes_ the NUL terminator, and strlcat() which ensures > that it won't overflow the buffer. Applying into omap-for-v4.10/fixes thanks. Tony From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933366AbcL0Rkb (ORCPT ); Tue, 27 Dec 2016 12:40:31 -0500 Received: from muru.com ([72.249.23.125]:53654 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933075AbcL0Rk0 (ORCPT ); Tue, 27 Dec 2016 12:40:26 -0500 Date: Tue, 27 Dec 2016 09:40:18 -0800 From: Tony Lindgren To: Maninder Singh Cc: bcousson@baylibre.com, paul@pwsan.com, linux@armlinux.org.uk, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, pankaj.m@samsung.com, ajeet.y@samsung.com, Vaneet Narang Subject: Re: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string Message-ID: <20161227174018.GT4920@atomide.com> References: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Maninder Singh [161207 20:16]: > Issue caught with static analysis tool: > "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)" > > Use strlcpy _includes_ the NUL terminator, and strlcat() which ensures > that it won't overflow the buffer. Applying into omap-for-v4.10/fixes thanks. Tony