From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Pavel Rojtberg <rojtberg@gmail.com>
Cc: linux-input@vger.kernel.org, pgriffais@valvesoftware.com,
gregkh@linuxfoundation.org
Subject: Re: [PATCH] Input: xpad - use correct product id for x360w controllers
Date: Tue, 27 Dec 2016 11:45:27 -0800 [thread overview]
Message-ID: <20161227194527.GA28140@dtor-ws> (raw)
In-Reply-To: <1482854518-9298-1-git-send-email-rojtberg@gmail.com>
On Tue, Dec 27, 2016 at 05:01:58PM +0100, Pavel Rojtberg wrote:
> From: Pavel Rojtberg <rojtberg@gmail.com>
>
> currently the controllers get the same product id as the wireless
> receiver. However the controllers actually have their own product id.
>
> The patch makes the driver expose the same product id as the windows
> driver.
>
> This improves compatibility when running applications with WINE.
>
> see https://github.com/paroj/xpad/issues/54
>
> Signed-off-by: Pavel Rojtberg <rojtberg@gmail.com>
Applied, thank you.
> ---
> drivers/input/joystick/xpad.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/input/joystick/xpad.c b/drivers/input/joystick/xpad.c
> index 098d8ec..34a2409 100644
> --- a/drivers/input/joystick/xpad.c
> +++ b/drivers/input/joystick/xpad.c
> @@ -1412,6 +1412,12 @@ static int xpad_init_input(struct usb_xpad *xpad)
> input_dev->name = xpad->name;
> input_dev->phys = xpad->phys;
> usb_to_input_id(xpad->udev, &input_dev->id);
> +
> + if(xpad->xtype == XTYPE_XBOX360W) {
> + /* x360w controllers and the receiver have different ids */
> + input_dev->id.product = 0x02a1;
> + }
> +
> input_dev->dev.parent = &xpad->intf->dev;
>
> input_set_drvdata(input_dev, xpad);
> --
> 2.7.4
>
--
Dmitry
prev parent reply other threads:[~2016-12-27 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-27 16:01 [PATCH] Input: xpad - use correct product id for x360w controllers Pavel Rojtberg
2016-12-27 19:45 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227194527.GA28140@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-input@vger.kernel.org \
--cc=pgriffais@valvesoftware.com \
--cc=rojtberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.