From: Eric Engestrom <eric@engestrom.ch>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: "Daniel Vetter" <daniel.vetter@ffwll.ch>,
"Joonas Lahtinen # Please enter the commit message for your
changes . Lines starting" <joonas.lahtinen@linux.intel.com>,
"DRI Development" <dri-devel@lists.freedesktop.org>,
"Daniel Vetter" <daniel.vetter@intel.com>,
"Christian König" <christian.koenig@amd.com>
Subject: Re: [PATCH] drm: Fix O= out-of-tree builds for selftests
Date: Wed, 28 Dec 2016 11:27:12 +0000 [thread overview]
Message-ID: <20161228112712.GA18700@engestrom.ch> (raw)
In-Reply-To: <20161228100959.GJ347@dvetter-linux.ger.corp.intel.com>
On Wednesday, 2016-12-28 11:09:59 +0100, Daniel Vetter wrote:
> On Wed, Dec 28, 2016 at 10:06:00AM +0000, Chris Wilson wrote:
> > On Wed, Dec 28, 2016 at 10:41:17AM +0100, Daniel Vetter wrote:
> > > Kbuild really doesn't like non-recursive Makefiles, but they do work
> > > as long as you build without O=
> > >
> > > Reported-by: kbuild test robot <fengguang.wu@intel.com>
> > > Fixes: 50f0033d1a0f ("drm: Add some kselftests for the DRM range manager (struct drm_mm)")
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Cc: Christian König <christian.koenig@amd.com>
> > > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com># Please enter the commit message for your changes. Lines starting
In case you haven't pushed it yet, the line above could be fixed :)
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> >
> > That's a shame, but it gets us over the breakage so
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> Thx for the review, applied.
>
> > For the next set of selftests we should add a common
> > CONFIG_DRM_SELFTESTS.
>
> Yeah, one for all of them is probably enough.
> -Daniel
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2016-12-28 11:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 9:41 [PATCH] drm: Fix O= out-of-tree builds for selftests Daniel Vetter
2016-12-28 10:06 ` Chris Wilson
2016-12-28 10:09 ` Daniel Vetter
2016-12-28 11:27 ` Eric Engestrom [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161228112712.GA18700@engestrom.ch \
--to=eric@engestrom.ch \
--cc=christian.koenig@amd.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.