All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Pattan, Reshma" <reshma.pattan@intel.com>
Cc: dev@dpdk.org, "De Lara Guarch,
	Pablo" <pablo.de.lara.guarch@intel.com>,
	"Ananyev, Konstantin" <konstantin.ananyev@intel.com>
Subject: Re: [PATCH v3] examples/l3fwd: fix validation for queue id	of config tuple
Date: Fri, 25 Mar 2016 19:49:10 +0100	[thread overview]
Message-ID: <2016370.aLXS1Y04Ta@xps13> (raw)
In-Reply-To: <E115CCD9D858EF4F90C690B0DCB4D8973C8D0C74@IRSMSX108.ger.corp.intel.com>

> > Added validation for queue id of config parameter tuple.
> > 
> > This validation enforces user to enter queue ids of a port
> > from 0 and in sequence.
> > 
> > This additional validation on queue ids avoids ixgbe crash caused by null
> > rxq pointer access inside ixgbe_dev_rx_init.
> > 
> > Reason for null rxq is, L3fwd application allocates memory only for queues
> > passed by user.
> > But rte_eth_dev_start  tries to initialize rx queues in sequence from 0 to
> > nb_rx_queues,
> > which is not true and coredump while accessing the unallocated queue .
> > 
> > Fixes: af75078fece3 ("first public release")
> > 
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> 
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>

Applied, thanks

      reply	other threads:[~2016-03-25 18:50 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-03-18 10:35 [PATCH] examples/l3fwd: fix validation for queue id of config tuple Reshma Pattan
2016-03-21 14:12 ` Thomas Monjalon
2016-03-24 23:11 ` [PATCH v2] " Reshma Pattan
2016-03-25 14:14   ` De Lara Guarch, Pablo
2016-03-25 15:13   ` [PATCH v3] " Reshma Pattan
2016-03-25 16:08     ` De Lara Guarch, Pablo
2016-03-25 18:49       ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2016370.aLXS1Y04Ta@xps13 \
    --to=thomas.monjalon@6wind.com \
    --cc=dev@dpdk.org \
    --cc=konstantin.ananyev@intel.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=reshma.pattan@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.