From: Thomas Monjalon <thomas@monjalon.net>
To: Fady Bader <fady@mellanox.com>
Cc: dev@dpdk.org, tbashar@mellanox.com, talshn@mellanox.com,
yohadt@mellanox.com, dmitry.kozliuk@gmail.com,
harini.ramakrishnan@microsoft.com, ocardona@microsoft.com,
ranjit.menon@intel.com, olivier.matz@6wind.com
Subject: Re: [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows
Date: Tue, 16 Jun 2020 11:04:20 +0200 [thread overview]
Message-ID: <2016768.FcZsOfyHcV@thomas> (raw)
In-Reply-To: <20200610120040.17968-4-fady@mellanox.com>
10/06/2020 14:00, Fady Bader:
> +/* SPDX-License-Identifier: BSD-3-Clause
> + * Copyright 2020 Mellanox Technologies, Ltd
> + */
Isn't it a different copyright?
Where does it come from?
> +
> +#ifndef _IN_H_
> +#define _IN_H_
> +
> +#define IPPROTO_IP 0
> +#define IPPROTO_HOPOPTS 0
> +#define IPPROTO_IPV4 4 /* IPv4 encapsulation */
> +#define IPPROTO_IPIP IPPROTO_IPV4 /* for compatibility */
> +#define IPPROTO_TCP 6
> +#define IPPROTO_UDP 17
> +#define IPPROTO_IPV6 41 /* IP6 header */
> +#define IPPROTO_ROUTING 43 /* IP6 routing header */
> +#define IPPROTO_FRAGMENT 44 /* IP6 fragmentation header */
> +#define IPPROTO_GRE 47 /* General Routing Encap. */
> +#define IPPROTO_ESP 50 /* IP6 Encap Sec. Payload */
> +#define IPPROTO_AH 51 /* IP6 Auth Header */
> +#define IPPROTO_NONE 59 /* IPv6 no next header */
> +#define IPPROTO_DSTOPTS 60 /* IP6 destination option */
> +#define IPPROTO_SCTP 132 /* Stream Control Transmission Protocol */
There are some tabs instead of space. Please double check.
next prev parent reply other threads:[~2020-06-16 9:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <'20200610112326.18576-1-fady@mellanox.com'>
2020-06-10 12:00 ` [dpdk-dev] [PATCH v2 0/3] compile librte_net for windows Fady Bader
2020-06-10 12:00 ` [dpdk-dev] [PATCH v2 1/3] net: fix s_addr redefinition in Windows Fady Bader
2020-06-10 12:00 ` [dpdk-dev] [PATCH v2 2/3] net: add htons to minGW for Windows Fady Bader
2020-06-10 12:33 ` Jerin Jacob
2020-06-10 12:00 ` [dpdk-dev] [PATCH v2 3/3] eal/windows: librte_net build on Windows Fady Bader
2020-06-16 9:04 ` Thomas Monjalon [this message]
2020-07-06 8:44 ` Fady Bader
2020-06-20 19:22 ` Dmitry Kozlyuk
2020-06-28 9:48 ` Fady Bader
2020-07-17 22:22 ` Narcisa Ana Maria Vasile
2020-07-20 12:54 ` Fady Bader
2020-07-20 16:26 ` Dmitry Kozlyuk
2020-07-22 10:20 ` Fady Bader
2020-07-22 10:30 ` Bruce Richardson
2020-07-27 8:54 ` Fady Bader
2020-07-27 8:53 ` Fady Bader
2020-07-08 8:25 ` [dpdk-dev] [PATCH v3 0/3] compile librte_net for windows Fady Bader
2020-07-08 8:25 ` [dpdk-dev] [PATCH v3 1/3] net: fix s_addr redefinition in Windows Fady Bader
2020-07-13 14:38 ` Olivier Matz
2020-07-15 6:26 ` Fady Bader
2020-07-08 8:25 ` [dpdk-dev] [PATCH v3 2/3] net: replace htons with rte_cpu_to_be_16 Fady Bader
2020-07-09 13:39 ` Morten Brørup
2020-07-13 14:38 ` Olivier Matz
2020-07-15 6:04 ` Fady Bader
2020-07-08 8:25 ` [dpdk-dev] [PATCH v3 3/3] eal/windows: librte_net build on Windows Fady Bader
2020-07-08 9:10 ` Thomas Monjalon
2020-07-08 10:19 ` Fady Bader
2020-07-23 7:08 ` [dpdk-dev] [PATCH v4 0/3] compile librte_net for windows Fady Bader
2020-07-23 7:08 ` [dpdk-dev] [PATCH v4 1/3] net: fix s_addr redefinition in Windows Fady Bader
2020-07-23 7:08 ` [dpdk-dev] [PATCH v4 2/3] net: replace htons with RTE_BE16 Fady Bader
2020-07-23 7:08 ` [dpdk-dev] [PATCH v4 3/3] eal/windows: librte_net build on Windows Fady Bader
2020-09-08 8:14 ` Ophir Munk
2020-07-24 1:11 ` [dpdk-dev] [PATCH v4 0/3] compile librte_net for windows Ranjit Menon
2020-09-10 19:55 ` Thomas Monjalon
2020-07-24 15:52 ` Kadam, Pallavi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2016768.FcZsOfyHcV@thomas \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=fady@mellanox.com \
--cc=harini.ramakrishnan@microsoft.com \
--cc=ocardona@microsoft.com \
--cc=olivier.matz@6wind.com \
--cc=ranjit.menon@intel.com \
--cc=talshn@mellanox.com \
--cc=tbashar@mellanox.com \
--cc=yohadt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.