Re: [PATCH rdma-core 3/4] debian/copyright: Add copyright information

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 2349 bytes --]

On Thu, Dec 29, 2016 at 08:25:37AM -0700, Jason Gunthorpe wrote:
> On Thu, Dec 29, 2016 at 03:49:07PM +0200, Leon Romanovsky wrote:
> > From: Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> >
> > This patch adds debian/copyright file and list all
> > different licences and copyrights, according to
> > debian policy.
>
> > +Files: *
> > +License: GPL-2+ or BSD
>
> We don't have anything that includes the 'any later version' clause in
> the copyright header required to be GPLv2+ - so everything should be simply
> 'GPL-2'

Right

>
> > +Files: debian/*
> > +Copyright: 2016 Talat Batheesh <talatb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
> > +License: GPL-2+
>
> You can add me here too

Sure with great pleasure.


>
> > +Files: buildlib/cbuild
> > +Copyright: 2015, 2016, Obsidian Research Corp. See COPYING.
> > +License: GPL-2+ or BSD
> > +
> > +Files: buildlib/fixup-include/*
> > +Copyright: 2016, Mellanox Technologies Ltd.
> > +License: GPL-2+ or BSD
>
> Many of these copyright attributions are a bit wonky :\ I personally
> think this format of Debian's is too difficult.
>
> > +Files: ccan/*
> > +Copyright: unspecified
> > +License: CC0 and BSD-MIT
> > +
> > +Files: ibacm/*
> > +Copyright: 2013-2015, Mellanox Technologies LTD.
> > +  2009-2014, Intel Corporation.
> > +License:  GPL-2 or OpenIB.org BSD (FreeBSD variant)
>
> There is no text stanza for 'OpenIB.org BSD'

Changed to be BSD

>
> > +Files: providers/ipathverbs/*
> > +Copyright: 2006-2009, QLogic Corp.
> > +  2005
> > +License: GPL-2+ or BSD
>
> ipath has a special license. Please review COPYING.md and make sure
> all the special cases called out are covered properly.

Thanks, I fixed it to be PathScale-BSD

>
> > +License: GPL-2+ or BSD
>
> I think this should just be 'BSD', same with all the 'or' stanzas.

I'm not a lawyer and in the rdma-core.spec it is "or".

Do you know which spec is correct one?
https://github.com/linux-rdma/rdma-core/blob/master/redhat/rdma-core.spec
https://github.com/linux-rdma/rdma-core/blob/master/rdma-core.spec

Meanwhile, I updated pull request with new version.

>
> I didn't see the intel bsd license in here (see
> providers/hfi1verbs/hfiverbs.c, it is slightly different again)
>
> It would be good to update COPYING.md to refer people to this new file
> as it is better than the short summary.
>
> Jason

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]