From: David Miller <davem@davemloft.net>
To: wr0112358@gmail.com
Cc: nhorman@tuxdriver.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drop_monitor: consider inserted data in genlmsg_end
Date: Mon, 02 Jan 2017 19:30:03 -0500 (EST) [thread overview]
Message-ID: <20170102.193003.577100357837775083.davem@davemloft.net> (raw)
In-Reply-To: <20170102233410.4070-1-wr0112358@gmail.com>
From: Reiter Wolfgang <wr0112358@gmail.com>
Date: Tue, 3 Jan 2017 00:34:10 +0100
> Final nlmsg_len field update must reflect inserted net_dm_drop_point
> data.
>
> This patch depends on previous patch:
> "drop_monitor: add missing call to genlmsg_end"
>
> Signed-off-by: Reiter Wolfgang <wr0112358@gmail.com>
Several coding style errors:
> @@ -112,6 +111,12 @@ static struct sk_buff *reset_per_cpu_data(struct per_cpu_dm_data *data)
> swap(data->skb, skb);
> spin_unlock_irqrestore(&data->lock, flags);
>
> + if(skb) {
There must be a space between "if" and "(skb)"
> + struct nlmsghdr *nlh = (struct nlmsghdr *)skb->data;
> + struct genlmsghdr *gnlh = (struct genlmsghdr *)nlmsg_data(nlh);
> + genlmsg_end(skb, genlmsg_data(gnlh));
> + }
There should be an empty line between the local variable declarations
and actual code.
next prev parent reply other threads:[~2017-01-03 0:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 23:34 [PATCH] drop_monitor: consider inserted data in genlmsg_end Reiter Wolfgang
2017-01-03 0:30 ` David Miller [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-01-03 0:39 Reiter Wolfgang
2017-01-03 13:09 ` Neil Horman
2017-01-03 14:54 ` David Miller
2017-01-03 16:04 ` Neil Horman
2017-01-03 16:10 ` David Miller
2017-01-03 23:09 ` Wolfgang Reiter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102.193003.577100357837775083.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=wr0112358@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.