From: Vinod Koul <vinod.koul@intel.com>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, sudeep.dutt@intel.com,
ashutosh.dixit@intel.com, dan.j.williams@intel.com,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: misc: mic: constify mbus_hw_ops structures
Date: Mon, 2 Jan 2017 10:40:43 +0530 [thread overview]
Message-ID: <20170102051043.GP3573@localhost> (raw)
In-Reply-To: <1482231377-25864-1-git-send-email-bhumirks@gmail.com>
On Tue, Dec 20, 2016 at 04:26:17PM +0530, Bhumika Goyal wrote:
> The fields of structure mbus_hw_ops are never modified after
> initialization, so declare these structures as const. Add a const
> annotation to all its initializations and uses like function arguments
> and pointers.
> Used Coccinelle to find all the occurences.
Can you please split these per driver so that they can be merged thru their
own subsystems.
--
~Vinod
prev parent reply other threads:[~2017-01-02 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-20 10:56 [PATCH] drivers: misc: mic: constify mbus_hw_ops structures Bhumika Goyal
2017-01-02 5:10 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102051043.GP3573@localhost \
--to=vinod.koul@intel.com \
--cc=ashutosh.dixit@intel.com \
--cc=bhumirks@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=julia.lawall@lip6.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.dutt@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.