From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1755274AbdABHp2 (ORCPT <rfc822;w@1wt.eu>);
        Mon, 2 Jan 2017 02:45:28 -0500
Received: from protonic.xs4all.nl ([83.163.252.89]:8784 "EHLO
        protonic.xs4all.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750834AbdABHp1 (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Jan 2017 02:45:27 -0500
Date: Mon, 2 Jan 2017 08:45:24 +0100
From: Robin van der Gracht <robin@protonic.nl>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Fengguang Wu <fengguang.wu@intel.com>,
        Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
Subject: Re: [PATCH] auxdisplay: fix new ht16k33 build errors
Message-ID: <20170102084524.3d603fd3@erd979>
In-Reply-To: <18889802-a96c-b71c-31d4-5f1d94903e70@infradead.org>
References: <18889802-a96c-b71c-31d4-5f1d94903e70@infradead.org>
Organization: Protonic Holland
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 26 Dec 2016 09:58:34 -0800
Randy Dunlap <rdunlap@infradead.org> wrote:

> From: Randy Dunlap <rdunlap@infradead.org>
> 
> Fix build errors caused by selecting incorrect kconfig symbols.
> 
> drivers/built-in.o:(.data+0x19cec): undefined reference to `sys_fillrect'
> drivers/built-in.o:(.data+0x19cf0): undefined reference to `sys_copyarea'
> drivers/built-in.o:(.data+0x19cf4): undefined reference to `sys_imageblit'
> 
> Fixes: 31114fa95bdb (auxdisplay: ht16k33: select framebuffer helper modules)
> 
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc:	Robin van der Gracht <robin@protonic.nl>
> Cc:	Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>
> Cc:	Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
>  drivers/auxdisplay/Kconfig |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> --- lnx-410-rc1.orig/drivers/auxdisplay/Kconfig
> +++ lnx-410-rc1/drivers/auxdisplay/Kconfig
> @@ -132,9 +132,9 @@ config HT16K33
>  	tristate "Holtek Ht16K33 LED controller with keyscan"
>  	depends on FB && OF && I2C && INPUT
>  	select FB_SYS_FOPS
> -	select FB_CFB_FILLRECT
> -	select FB_CFB_COPYAREA
> -	select FB_CFB_IMAGEBLIT
> +	select FB_SYS_FILLRECT
> +	select FB_SYS_COPYAREA
> +	select FB_SYS_IMAGEBLIT
>  	select INPUT_MATRIXKMAP
>  	select FB_BACKLIGHT
>  	help

Acked-by: Robin van der Gracht <robin@protonic.nl>