All of lore.kernel.org
 help / color / mirror / Atom feed
From: Lukas Wunner <lukas-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
To: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
Cc: Ard Biesheuvel
	<ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org
Subject: Re: [PATCH] efi: use typed function pointers for runtime services table
Date: Mon, 2 Jan 2017 11:42:55 +0100	[thread overview]
Message-ID: <20170102104255.GA20016@wunner.de> (raw)
In-Reply-To: <20161124213451.GA3549-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>

On Thu, Nov 24, 2016 at 09:34:51PM +0000, Matt Fleming wrote:
> On Wed, 23 Nov, at 10:42:44AM, Ard Biesheuvel wrote:
> > Instead of using void pointers, and casting them to correctly typed
> > function pointers upon use, declare the runtime services pointers
> > as function pointers using their respective prototypes, for which
> > typedefs are already available.
> > 
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > ---
> > 
> > Build tested on arm64 only
> 
> Builds fine for i386, x86-64 and ia64 too.
> 
> Reviewed-by: Matt Fleming <matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>

This hasn't been applied to efi.git/next yet so I resubmitted as part
of my consification series.  (And I'm afraid I forgot to include your
Reviewed-by, sorry.)

Thanks,

Lukas

  parent reply	other threads:[~2017-01-02 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-23 10:42 [PATCH] efi: use typed function pointers for runtime services table Ard Biesheuvel
     [not found] ` <1479897764-29871-1-git-send-email-ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-11-24 21:34   ` Matt Fleming
     [not found]     ` <20161124213451.GA3549-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org>
2017-01-02 10:42       ` Lukas Wunner [this message]
     [not found]         ` <20170102104255.GA20016-JFq808J9C/izQB+pC5nmwQ@public.gmane.org>
2017-01-04 18:16           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102104255.GA20016@wunner.de \
    --to=lukas-jfq808j9c/izqb+pc5nmwq@public.gmane.org \
    --cc=ard.biesheuvel-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=dhowells-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=linux-efi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
    --cc=matt-mF/unelCI9GS6iBeEJttW/XRex20P6io@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.