Re: [PATCH nf-next 1/2] netfilter: select LIBCRC32C together with SCTP conntrack

[Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>]

On Mon, Jan 02, 2017 at 01:29:40PM +0100, Davide Caratti wrote:
> nf_conntrack needs to compute crc32c when dealing with SCTP packets.
> Moreover, NF_NAT_PROTO_SCTP (currently selecting LIBCRC32C) can be enabled
> only if conntrack support for SCTP is enabled. Therefore, move enabling of
> kernel support for crc32c so that it is selected when NF_CT_PROTO_SCTP=y.
> 
> Signed-off-by: Davide Caratti <dcaratti@redhat.com>

Reviewed-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>

> ---
>  net/netfilter/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/netfilter/Kconfig b/net/netfilter/Kconfig
> index 63729b4..6d425e3 100644
> --- a/net/netfilter/Kconfig
> +++ b/net/netfilter/Kconfig
> @@ -162,6 +162,7 @@ config NF_CT_PROTO_SCTP
>  	bool 'SCTP protocol connection tracking support'
>  	depends on NETFILTER_ADVANCED
>  	default y
> +	select LIBCRC32C
>  	help
>  	  With this option enabled, the layer 3 independent connection
>  	  tracking code will be able to do state tracking on SCTP connections.
> @@ -397,7 +398,6 @@ config NF_NAT_PROTO_SCTP
>  	bool
>  	default NF_NAT && NF_CT_PROTO_SCTP
>  	depends on NF_NAT && NF_CT_PROTO_SCTP
> -	select LIBCRC32C
>  
>  config NF_NAT_AMANDA
>  	tristate
> -- 
> 2.7.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netfilter-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>