All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: devel@linuxdriverproject.org
Cc: linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Haiyang Zhang <haiyangz@microsoft.com>,
	John Stultz <john.stultz@linaro.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Alex Ng <alexng@microsoft.com>
Subject: [PATCH 4/4] hv_util: improve time adjustment accuracy by disabling interrupts
Date: Mon,  2 Jan 2017 20:41:14 +0100	[thread overview]
Message-ID: <20170102194114.657-5-vkuznets@redhat.com> (raw)
In-Reply-To: <20170102194114.657-1-vkuznets@redhat.com>

If we happen to receive interrupts during hv_set_host_time() execution
our adjustments may get inaccurate. Make the whole function atomic.
Unfortunately, we can's call do_settimeofday64() with interrupts
disabled as some cross-CPU work is being done but this call happens
very rarely.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/hv/hv_util.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/hv/hv_util.c b/drivers/hv/hv_util.c
index 4c0fbb0..233d5cb 100644
--- a/drivers/hv/hv_util.c
+++ b/drivers/hv/hv_util.c
@@ -186,6 +186,9 @@ static void hv_set_host_time(struct work_struct *work)
 	u64 newtime;
 	struct timespec64 host_ts, our_ts;
 	struct timex txc = {0};
+	unsigned long flags;
+
+	local_irq_save(flags);
 
 	wrk = container_of(work, struct adj_time_work, work);
 
@@ -214,6 +217,7 @@ static void hv_set_host_time(struct work_struct *work)
 
 	/* Try adjusting time by using phase adjustment if possible */
 	if (abs(delta) > MAXPHASE) {
+		local_irq_restore(flags);
 		do_settimeofday64(&host_ts);
 		return;
 	}
@@ -225,6 +229,8 @@ static void hv_set_host_time(struct work_struct *work)
 	txc.status = STA_PLL;
 	txc.offset = delta;
 	do_adjtimex(&txc);
+
+	local_irq_restore(flags);
 }
 
 /*
-- 
2.9.3

  parent reply	other threads:[~2017-01-02 19:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 19:41 [PATCH 0/4] hv_util: adjust system time smoothly Vitaly Kuznetsov
2017-01-02 19:41 ` [PATCH 1/4] timekeeping: export do_adjtimex() to modules Vitaly Kuznetsov
2017-01-02 19:41 ` [PATCH 2/4] hv_util: switch to using timespec64 Vitaly Kuznetsov
2017-01-02 19:41 ` [PATCH 3/4] hv_util: use do_adjtimex() to update system time Vitaly Kuznetsov
2017-01-02 23:24   ` Alex Ng (LIS)
2017-01-03 12:32     ` Vitaly Kuznetsov
2017-01-03 19:48       ` Alex Ng (LIS)
2017-01-09 17:19         ` Stephen Hemminger
2017-01-09 17:40           ` Vitaly Kuznetsov
2017-01-09 17:58             ` Stephen Hemminger
2017-01-09 18:14               ` Vitaly Kuznetsov
2017-01-09 18:31                 ` Stephen Hemminger
2017-01-02 19:41 ` Vitaly Kuznetsov [this message]
2017-01-02 19:50   ` [PATCH 4/4] hv_util: improve time adjustment accuracy by disabling interrupts Stephen Hemminger
2017-01-03 12:28     ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170102194114.657-5-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=alexng@microsoft.com \
    --cc=devel@linuxdriverproject.org \
    --cc=haiyangz@microsoft.com \
    --cc=john.stultz@linaro.org \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.