From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Gary Bisson <gary.bisson@boundarydevices.com>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers
Date: Mon, 2 Jan 2017 14:00:54 -0800 [thread overview]
Message-ID: <20170102220053.GG9325@atomide.com> (raw)
In-Reply-To: <CACRpkdYOq_v2N7q3P1C=Q2u8K1Jdhjem_Ry+v2r9f+ik_gKGqg@mail.gmail.com>
* Linus Walleij <linus.walleij@linaro.org> [170102 13:44]:
> On Mon, Jan 2, 2017 at 7:20 PM, Gary Bisson
> <gary.bisson@boundarydevices.com> wrote:
>
> > This series is a follow-up to Linus suggestion to use the generic helpers
> > introduced by Tony [1].
> >
> > Mainly I've used the generic functions in pinctrl_ops and pinmux_ops and
> > switched to the generic group/function_desc structures instead of the
> > imx-specific one that didn't bring anything special.
>
> Awesome job. Really nice!
>
> > However I couldn't use the 'add' functions to add elements since the
> > parsing is done at probe time in its own way. So I've kept the
> > radix_insert functions. This could be modified in the future though.
>
> Let's see if Tony has some ideas. We already save a bunch of
> code by this which is very nice.
I attempted a generic iterator in the ti-iodelay.c but so far
did not really manage to simplify it at all..
Tony
prev parent reply other threads:[~2017-01-02 22:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 18:20 [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers Gary Bisson
2017-01-02 18:20 ` [PATCH 1/2] pinctrl: imx: use generic pinctrl helpers for managing groups Gary Bisson
2017-01-02 21:41 ` Linus Walleij
2017-03-07 17:19 ` Fabio Estevam
2017-03-07 17:26 ` Gary Bisson
2017-03-07 17:37 ` Fabio Estevam
2017-03-07 17:54 ` Tony Lindgren
2017-03-15 9:46 ` Linus Walleij
2017-03-29 13:33 ` Fabio Estevam
2017-03-29 16:26 ` Tony Lindgren
2017-03-30 9:05 ` Linus Walleij
2017-03-30 15:05 ` Tony Lindgren
2017-01-02 18:20 ` [PATCH 2/2] pinctrl: imx: use generic pinmux helpers for managing functions Gary Bisson
2017-01-02 21:42 ` Linus Walleij
2017-01-02 21:43 ` [PATCH 0/2] pinctrl: imx: use generic pinctrl helpers Linus Walleij
2017-01-02 22:00 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170102220053.GG9325@atomide.com \
--to=tony@atomide.com \
--cc=fabio.estevam@nxp.com \
--cc=gary.bisson@boundarydevices.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.