Re: [PATCH v3 1/2] net/vhost: create datagram sockets immediately

[Yuanhan Liu <yuanhan.liu@linux.intel.com>]

On Sun, Jan 01, 2017 at 02:01:56PM -0500, Charles (Chas) Williams wrote:
> If you create a vhost server device, it doesn't create the actual datagram
> socket until you call .dev_start().  If you call .dev_stop() is also
> deletes those sockets.  For QEMU clients, this is a problem since QEMU
> doesn't know how to re-attach to datagram sockets that have gone away.
> 
> To work around this, register and unregister the datagram sockets during

I will not call it's a "workaround", instead, it's a "fix" to me.

> device creation and removal.
> 
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
> 
> Signed-off-by: Chas Williams <ciwillia@brocade.com>
> ---
>  drivers/net/vhost/rte_eth_vhost.c | 43 ++++++++++++++++-----------------------
>  1 file changed, 17 insertions(+), 26 deletions(-)
> 
> diff --git a/drivers/net/vhost/rte_eth_vhost.c b/drivers/net/vhost/rte_eth_vhost.c
> index 60b0f51..6b11e40 100644
> --- a/drivers/net/vhost/rte_eth_vhost.c
> +++ b/drivers/net/vhost/rte_eth_vhost.c
> @@ -114,8 +114,6 @@ struct pmd_internal {
>  	char *iface_name;
>  	uint16_t max_queues;
>  	uint64_t flags;

I think the "flags" could also be dropped in this patch: no user any
more.

	--yliu