From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757729AbdACKgr (ORCPT ); Tue, 3 Jan 2017 05:36:47 -0500 Received: from merlin.infradead.org ([205.233.59.134]:34612 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750879AbdACKgm (ORCPT ); Tue, 3 Jan 2017 05:36:42 -0500 Date: Tue, 3 Jan 2017 11:36:34 +0100 From: Peter Zijlstra To: linux-kernel@vger.kernel.org, mingo@kernel.org, tglx@linutronix.de, hpa@zytor.com Cc: linux-tip-commits@vger.kernel.org Subject: Re: [tip:timers/urgent] ktime: Get rid of the union Message-ID: <20170103103634.GA25813@worktop.programming.kicks-ass.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Dec 25, 2016 at 05:26:33AM -0800, tip-bot for Thomas Gleixner wrote: > Commit-ID: 64dac5c9e0f5a933e4520f0cb689b7b143925207 > Gitweb: http://git.kernel.org/tip/64dac5c9e0f5a933e4520f0cb689b7b143925207 > Author: Thomas Gleixner > AuthorDate: Sun, 25 Dec 2016 11:38:40 +0100 > Committer: Thomas Gleixner > CommitDate: Sun, 25 Dec 2016 13:11:50 +0100 > > ktime: Get rid of the union > > ktime is a union because the initial implementation stored the time in > scalar nanoseconds on 64 bit machine and in a endianess optimized timespec > variant for 32bit machines. The Y2038 cleanup removed the timespec variant > and switched everything to scalar nanoseconds. The union remained, but > become completely pointless. > > Get rid of the union and just keep ktime_t as simple typedef of type s64. All good stuff. One question that remains is why keep the type while removing the cycles_t type?