From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH 2/5] mfd: twl: remove useless header Date: Tue, 3 Jan 2017 15:30:50 +0000 Message-ID: <20170103153050.GH2977@dell> References: <20161126181326.14951-1-Nicolae_Rosia@mentor.com> <20161126181326.14951-3-Nicolae_Rosia@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20161126181326.14951-3-Nicolae_Rosia@mentor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Nicolae Rosia Cc: Mark Rutland , devicetree@vger.kernel.org, Baruch Siach , Tony Lindgren , Liam Girdwood , Rob Herring , linux-kernel@vger.kernel.org, Paul Gortmaker , Mark Brown , Graeme Gregory , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org List-Id: linux-omap@vger.kernel.org T24gU2F0LCAyNiBOb3YgMjAxNiwgTmljb2xhZSBSb3NpYSB3cm90ZToKCj4gVGhpcyBoZWFkZXIg aGFzIG9uZSB1c2VyLCB0d2wtY29yZS5jIC4KPiBSZW1vdmUgaXQgYmVmb3JlIGl0IGdldHMgbW9y ZSB1c2Vycy4KClRoZSBoZWFkZXIgaXMgbm90IHVzZWxlc3MuICBJdCBwcmV2ZW50cyB1cyBmcm9t IGhhdmluZyB0byBwbGFjZQpleHRlcm5hbCBwcm90b3R5cGVzIGludG8gQyBmaWxlcy4KCj4gU2ln bmVkLW9mZi1ieTogTmljb2xhZSBSb3NpYSA8Tmljb2xhZV9Sb3NpYUBtZW50b3IuY29tPgo+IC0t LQo+ICBkcml2ZXJzL21mZC90d2wtY29yZS5jICAgIHwgIDggKysrKysrLS0KPiAgZHJpdmVycy9t ZmQvdHdsLWNvcmUuaCAgICB8IDEwIC0tLS0tLS0tLS0KPiAgZHJpdmVycy9tZmQvdHdsNDAzMC1p cnEuYyB8ICAyIC0tCj4gIGRyaXZlcnMvbWZkL3R3bDYwMzAtaXJxLmMgfCAgMiAtLQo+ICA0IGZp bGVzIGNoYW5nZWQsIDYgaW5zZXJ0aW9ucygrKSwgMTYgZGVsZXRpb25zKC0pCj4gIGRlbGV0ZSBt b2RlIDEwMDY0NCBkcml2ZXJzL21mZC90d2wtY29yZS5oCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvbWZkL3R3bC1jb3JlLmMgYi9kcml2ZXJzL21mZC90d2wtY29yZS5jCj4gaW5kZXggNDhiMDY2 OC4uZTE2MDg0ZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21mZC90d2wtY29yZS5jCj4gKysrIGIv ZHJpdmVycy9tZmQvdHdsLWNvcmUuYwo+IEBAIC01Miw4ICs1Miw2IEBACj4gIC8qIFJlZ2lzdGVy IGRlc2NyaXB0aW9ucyBmb3IgYXVkaW8gKi8KPiAgI2luY2x1ZGUgPGxpbnV4L21mZC90d2w0MDMw LWF1ZGlvLmg+Cj4gIAo+IC0jaW5jbHVkZSAidHdsLWNvcmUuaCIKPiAtCj4gIC8qCj4gICAqIFRo ZSBUV0w0MDMwICJUcml0b24gMiIgaXMgb25lIG9mIGEgZmFtaWx5IG9mIGEgbXVsdGktZnVuY3Rp b24gIlBvd2VyCj4gICAqIE1hbmFnZW1lbnQgYW5kIFN5c3RlbSBDb21wYW5pb24gRGV2aWNlIiBj aGlwcyBvcmlnaW5hbGx5IGRlc2lnbmVkIGZvcgo+IEBAIC0xNTAsNiArMTQ4LDEyIEBACj4gIAo+ ICAvKi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0qLwo+ICAKPiAraW50IHR3bDYwMzBfaW5pdF9pcnEoc3RydWN0IGRl dmljZSAqZGV2LCBpbnQgaXJxX251bSk7Cj4gK2ludCB0d2w2MDMwX2V4aXRfaXJxKHZvaWQpOwo+ ICtpbnQgdHdsNDAzMF9pbml0X2lycShzdHJ1Y3QgZGV2aWNlICpkZXYsIGludCBpcnFfbnVtKTsK PiAraW50IHR3bDQwMzBfZXhpdF9pcnEodm9pZCk7Cj4gK2ludCB0d2w0MDMwX2luaXRfY2hpcF9p cnEoY29uc3QgY2hhciAqY2hpcCk7Cj4gKwo+ICAvKiBTdHJ1Y3R1cmUgZm9yIGVhY2ggVFdMNDAz MC9UV0w2MDMwIFNsYXZlICovCj4gIHN0cnVjdCB0d2xfY2xpZW50IHsKPiAgCXN0cnVjdCBpMmNf Y2xpZW50ICpjbGllbnQ7Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWZkL3R3bC1jb3JlLmggYi9k cml2ZXJzL21mZC90d2wtY29yZS5oCj4gZGVsZXRlZCBmaWxlIG1vZGUgMTAwNjQ0Cj4gaW5kZXgg NmZmOTlkYy4uMDAwMDAwMAo+IC0tLSBhL2RyaXZlcnMvbWZkL3R3bC1jb3JlLmgKPiArKysgL2Rl di9udWxsCj4gQEAgLTEsMTAgKzAsMCBAQAo+IC0jaWZuZGVmIF9fVFdMX0NPUkVfSF9fCj4gLSNk ZWZpbmUgX19UV0xfQ09SRV9IX18KPiAtCj4gLWV4dGVybiBpbnQgdHdsNjAzMF9pbml0X2lycShz dHJ1Y3QgZGV2aWNlICpkZXYsIGludCBpcnFfbnVtKTsKPiAtZXh0ZXJuIGludCB0d2w2MDMwX2V4 aXRfaXJxKHZvaWQpOwo+IC1leHRlcm4gaW50IHR3bDQwMzBfaW5pdF9pcnEoc3RydWN0IGRldmlj ZSAqZGV2LCBpbnQgaXJxX251bSk7Cj4gLWV4dGVybiBpbnQgdHdsNDAzMF9leGl0X2lycSh2b2lk KTsKPiAtZXh0ZXJuIGludCB0d2w0MDMwX2luaXRfY2hpcF9pcnEoY29uc3QgY2hhciAqY2hpcCk7 Cj4gLQo+IC0jZW5kaWYgLyogIF9fVFdMX0NPUkVfSF9fICovCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvbWZkL3R3bDQwMzAtaXJxLmMgYi9kcml2ZXJzL21mZC90d2w0MDMwLWlycS5jCj4gaW5kZXgg YjQ2YzBjZi4uMDAwYzIzMSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21mZC90d2w0MDMwLWlycS5j Cj4gKysrIGIvZHJpdmVycy9tZmQvdHdsNDAzMC1pcnEuYwo+IEBAIC0zNSw4ICszNSw2IEBACj4g ICNpbmNsdWRlIDxsaW51eC9pcnFkb21haW4uaD4KPiAgI2luY2x1ZGUgPGxpbnV4L2kyYy90d2wu aD4KPiAgCj4gLSNpbmNsdWRlICJ0d2wtY29yZS5oIgo+IC0KPiAgLyoKPiAgICogVFdMNDAzMCBJ UlEgaGFuZGxpbmcgaGFzIHR3byBzdGFnZXMgaW4gaGFyZHdhcmUsIGFuZCB0aHVzIGluIHNvZnR3 YXJlLgo+ICAgKiBUaGUgUHJpbWFyeSBJbnRlcnJ1cHQgSGFuZGxlciAoUElIKSBzdGFnZSBleHBv c2VzIHN0YXR1cyBiaXRzIHNheWluZwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21mZC90d2w2MDMw LWlycS5jIGIvZHJpdmVycy9tZmQvdHdsNjAzMC1pcnEuYwo+IGluZGV4IDUzNTc0NTAuLjYzZWNh NzYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9tZmQvdHdsNjAzMC1pcnEuYwo+ICsrKyBiL2RyaXZl cnMvbWZkL3R3bDYwMzAtaXJxLmMKPiBAQCAtNDIsOCArNDIsNiBAQAo+ICAjaW5jbHVkZSA8bGlu dXgvaXJxZG9tYWluLmg+Cj4gICNpbmNsdWRlIDxsaW51eC9vZl9kZXZpY2UuaD4KPiAgCj4gLSNp bmNsdWRlICJ0d2wtY29yZS5oIgo+IC0KPiAgLyoKPiAgICogVFdMNjAzMCAodW5saWtlIGl0cyBw cmVkZWNlc3NvcnMsIHdoaWNoIGhhZCB0d28gbGV2ZWwgaW50ZXJydXB0IGhhbmRsaW5nKQo+ICAg KiB0aHJlZSBpbnRlcnJ1cHQgcmVnaXN0ZXJzIElOVF9TVFNfQSwgSU5UX1NUU19CIGFuZCBJTlRf U1RTX0MuCgotLSAKTGVlIEpvbmVzCkxpbmFybyBTVE1pY3JvZWxlY3Ryb25pY3MgTGFuZGluZyBU ZWFtIExlYWQKTGluYXJvLm9yZyDilIIgT3BlbiBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0Nz CkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwgVHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: lee.jones@linaro.org (Lee Jones) Date: Tue, 3 Jan 2017 15:30:50 +0000 Subject: [PATCH 2/5] mfd: twl: remove useless header In-Reply-To: <20161126181326.14951-3-Nicolae_Rosia@mentor.com> References: <20161126181326.14951-1-Nicolae_Rosia@mentor.com> <20161126181326.14951-3-Nicolae_Rosia@mentor.com> Message-ID: <20170103153050.GH2977@dell> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sat, 26 Nov 2016, Nicolae Rosia wrote: > This header has one user, twl-core.c . > Remove it before it gets more users. The header is not useless. It prevents us from having to place external prototypes into C files. > Signed-off-by: Nicolae Rosia > --- > drivers/mfd/twl-core.c | 8 ++++++-- > drivers/mfd/twl-core.h | 10 ---------- > drivers/mfd/twl4030-irq.c | 2 -- > drivers/mfd/twl6030-irq.c | 2 -- > 4 files changed, 6 insertions(+), 16 deletions(-) > delete mode 100644 drivers/mfd/twl-core.h > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index 48b0668..e16084e 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -52,8 +52,6 @@ > /* Register descriptions for audio */ > #include > > -#include "twl-core.h" > - > /* > * The TWL4030 "Triton 2" is one of a family of a multi-function "Power > * Management and System Companion Device" chips originally designed for > @@ -150,6 +148,12 @@ > > /*----------------------------------------------------------------------*/ > > +int twl6030_init_irq(struct device *dev, int irq_num); > +int twl6030_exit_irq(void); > +int twl4030_init_irq(struct device *dev, int irq_num); > +int twl4030_exit_irq(void); > +int twl4030_init_chip_irq(const char *chip); > + > /* Structure for each TWL4030/TWL6030 Slave */ > struct twl_client { > struct i2c_client *client; > diff --git a/drivers/mfd/twl-core.h b/drivers/mfd/twl-core.h > deleted file mode 100644 > index 6ff99dc..0000000 > --- a/drivers/mfd/twl-core.h > +++ /dev/null > @@ -1,10 +0,0 @@ > -#ifndef __TWL_CORE_H__ > -#define __TWL_CORE_H__ > - > -extern int twl6030_init_irq(struct device *dev, int irq_num); > -extern int twl6030_exit_irq(void); > -extern int twl4030_init_irq(struct device *dev, int irq_num); > -extern int twl4030_exit_irq(void); > -extern int twl4030_init_chip_irq(const char *chip); > - > -#endif /* __TWL_CORE_H__ */ > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c > index b46c0cf..000c231 100644 > --- a/drivers/mfd/twl4030-irq.c > +++ b/drivers/mfd/twl4030-irq.c > @@ -35,8 +35,6 @@ > #include > #include > > -#include "twl-core.h" > - > /* > * TWL4030 IRQ handling has two stages in hardware, and thus in software. > * The Primary Interrupt Handler (PIH) stage exposes status bits saying > diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c > index 5357450..63eca76 100644 > --- a/drivers/mfd/twl6030-irq.c > +++ b/drivers/mfd/twl6030-irq.c > @@ -42,8 +42,6 @@ > #include > #include > > -#include "twl-core.h" > - > /* > * TWL6030 (unlike its predecessors, which had two level interrupt handling) > * three interrupt registers INT_STS_A, INT_STS_B and INT_STS_C. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org ? Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935395AbdACPg3 (ORCPT ); Tue, 3 Jan 2017 10:36:29 -0500 Received: from mail-wm0-f50.google.com ([74.125.82.50]:37148 "EHLO mail-wm0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758724AbdACPgV (ORCPT ); Tue, 3 Jan 2017 10:36:21 -0500 Date: Tue, 3 Jan 2017 15:30:50 +0000 From: Lee Jones To: Nicolae Rosia Cc: Mark Brown , Rob Herring , Mark Rutland , Tony Lindgren , Liam Girdwood , Paul Gortmaker , Graeme Gregory , Baruch Siach , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/5] mfd: twl: remove useless header Message-ID: <20170103153050.GH2977@dell> References: <20161126181326.14951-1-Nicolae_Rosia@mentor.com> <20161126181326.14951-3-Nicolae_Rosia@mentor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20161126181326.14951-3-Nicolae_Rosia@mentor.com> User-Agent: Mutt/1.6.2 (2016-07-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 26 Nov 2016, Nicolae Rosia wrote: > This header has one user, twl-core.c . > Remove it before it gets more users. The header is not useless. It prevents us from having to place external prototypes into C files. > Signed-off-by: Nicolae Rosia > --- > drivers/mfd/twl-core.c | 8 ++++++-- > drivers/mfd/twl-core.h | 10 ---------- > drivers/mfd/twl4030-irq.c | 2 -- > drivers/mfd/twl6030-irq.c | 2 -- > 4 files changed, 6 insertions(+), 16 deletions(-) > delete mode 100644 drivers/mfd/twl-core.h > > diff --git a/drivers/mfd/twl-core.c b/drivers/mfd/twl-core.c > index 48b0668..e16084e 100644 > --- a/drivers/mfd/twl-core.c > +++ b/drivers/mfd/twl-core.c > @@ -52,8 +52,6 @@ > /* Register descriptions for audio */ > #include > > -#include "twl-core.h" > - > /* > * The TWL4030 "Triton 2" is one of a family of a multi-function "Power > * Management and System Companion Device" chips originally designed for > @@ -150,6 +148,12 @@ > > /*----------------------------------------------------------------------*/ > > +int twl6030_init_irq(struct device *dev, int irq_num); > +int twl6030_exit_irq(void); > +int twl4030_init_irq(struct device *dev, int irq_num); > +int twl4030_exit_irq(void); > +int twl4030_init_chip_irq(const char *chip); > + > /* Structure for each TWL4030/TWL6030 Slave */ > struct twl_client { > struct i2c_client *client; > diff --git a/drivers/mfd/twl-core.h b/drivers/mfd/twl-core.h > deleted file mode 100644 > index 6ff99dc..0000000 > --- a/drivers/mfd/twl-core.h > +++ /dev/null > @@ -1,10 +0,0 @@ > -#ifndef __TWL_CORE_H__ > -#define __TWL_CORE_H__ > - > -extern int twl6030_init_irq(struct device *dev, int irq_num); > -extern int twl6030_exit_irq(void); > -extern int twl4030_init_irq(struct device *dev, int irq_num); > -extern int twl4030_exit_irq(void); > -extern int twl4030_init_chip_irq(const char *chip); > - > -#endif /* __TWL_CORE_H__ */ > diff --git a/drivers/mfd/twl4030-irq.c b/drivers/mfd/twl4030-irq.c > index b46c0cf..000c231 100644 > --- a/drivers/mfd/twl4030-irq.c > +++ b/drivers/mfd/twl4030-irq.c > @@ -35,8 +35,6 @@ > #include > #include > > -#include "twl-core.h" > - > /* > * TWL4030 IRQ handling has two stages in hardware, and thus in software. > * The Primary Interrupt Handler (PIH) stage exposes status bits saying > diff --git a/drivers/mfd/twl6030-irq.c b/drivers/mfd/twl6030-irq.c > index 5357450..63eca76 100644 > --- a/drivers/mfd/twl6030-irq.c > +++ b/drivers/mfd/twl6030-irq.c > @@ -42,8 +42,6 @@ > #include > #include > > -#include "twl-core.h" > - > /* > * TWL6030 (unlike its predecessors, which had two level interrupt handling) > * three interrupt registers INT_STS_A, INT_STS_B and INT_STS_C. -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog