From mboxrd@z Thu Jan  1 00:00:00 1970
From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
Subject: Re: [PATCH] mk: disable ICC warning 188
Date: Tue, 3 Jan 2017 18:19:07 +0100
Message-ID: <20170103171907.GD12822@6wind.com>
References: <20170103161542.27303-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, Thomas Monjalon <thomas.monjalon@6wind.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44])
 by dpdk.org (Postfix) with ESMTP id 9E3B14A63
 for <dev@dpdk.org>; Tue,  3 Jan 2017 18:19:14 +0100 (CET)
Received: by mail-wm0-f44.google.com with SMTP id t79so435100065wmt.0
 for <dev@dpdk.org>; Tue, 03 Jan 2017 09:19:14 -0800 (PST)
Content-Disposition: inline
In-Reply-To: <20170103161542.27303-1-ferruh.yigit@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Jan 03, 2017 at 04:15:42PM +0000, Ferruh Yigit wrote:
> error #188: enumerated type mixed with another type
> 
> This is get when an integer assigned to an enum variable.
> 
> Since this usage is common and causing many ICC compilation errors, and
> other compilers accept this usage. Disabling the warning.
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
>  mk/toolchain/icc/rte.vars.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/mk/toolchain/icc/rte.vars.mk b/mk/toolchain/icc/rte.vars.mk
> index ba69f1f..86d9ef7 100644
> --- a/mk/toolchain/icc/rte.vars.mk
> +++ b/mk/toolchain/icc/rte.vars.mk
> @@ -71,6 +71,7 @@ TOOLCHAIN_ASFLAGS =
>  #                   was declared "deprecated"
>  WERROR_FLAGS := -Wall -w2 -diag-disable 271 -diag-warning 1478
>  WERROR_FLAGS += -diag-disable 13368 -diag-disable 15527
> +WERROR_FLAGS += -diag-disable 188
>  
>  ifeq ($(RTE_DEVEL_BUILD),y)
>  WERROR_FLAGS += -Werror-all
> -- 
> 2.9.3

I also think this warning may be useful but is not worth the trouble in many
cases, thus:

Acked-by: Adrien Mazarguil <adrien.mazarguil@6wind.com>

-- 
Adrien Mazarguil
6WIND