Re: [PATCH 3/5] mfd: axp20x: Fix axp288 PEK_DBR and PEK_DBF irqs being swapped

[Lee Jones <lee.jones@linaro.org>]

On Wed, 14 Dec 2016, Hans de Goede wrote:

> The R in PEK_DBR stands for rising, so it should be mapped to
> AXP288_IRQ_POKP where the last P stands for positive edge.
> 
> Likewise PEK_DBF should be mapped to the falling edge, aka the
> _N_egative edge, so it should be mapped to AXP288_IRQ_POKN.
> 
> This fixes the inverted powerbutton status reporting by the
> axp20x-pek driver.
> 
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
>  drivers/mfd/axp20x.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied, thanks.

> diff --git a/drivers/mfd/axp20x.c b/drivers/mfd/axp20x.c
> index 9a81659..a294121 100644
> --- a/drivers/mfd/axp20x.c
> +++ b/drivers/mfd/axp20x.c
> @@ -205,14 +205,14 @@ static struct resource axp22x_pek_resources[] = {
>  static struct resource axp288_power_button_resources[] = {
>  	{
>  		.name	= "PEK_DBR",
> -		.start	= AXP288_IRQ_POKN,
> -		.end	= AXP288_IRQ_POKN,
> +		.start	= AXP288_IRQ_POKP,
> +		.end	= AXP288_IRQ_POKP,
>  		.flags	= IORESOURCE_IRQ,
>  	},
>  	{
>  		.name	= "PEK_DBF",
> -		.start	= AXP288_IRQ_POKP,
> -		.end	= AXP288_IRQ_POKP,
> +		.start	= AXP288_IRQ_POKN,
> +		.end	= AXP288_IRQ_POKN,
>  		.flags	= IORESOURCE_IRQ,
>  	},
>  };

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog