From: Arnaldo Carvalho de Melo <acme@kernel.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>, Andi Kleen <andi@firstfloor.org>,
jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] perf, tools: Add probing for xed
Date: Tue, 3 Jan 2017 15:39:46 -0300 [thread overview]
Message-ID: <20170103183946.GK27864@kernel.org> (raw)
In-Reply-To: <20170103151106.GX8388@tassilo.jf.intel.com>
Em Tue, Jan 03, 2017 at 07:11:06AM -0800, Andi Kleen escreveu:
> > please don't put it in FEATURE_DISPLAY.. AFAICS there's not any xed
> > package yet, just the sources, so the "xed: OFF" build message would
> > bother almost everyone probably for long time..
>
> It should be eventually packaged. How would people know they are missing
> it without displaying it? I think it has to, otherwise most people will
> miss out on the feature. Silent failure is bad.
Right, you have a point, we should have some warning to the user for
when features are not being automatically probed for, i.e. extra
features may be enabled using special command line settings, read the
docs to see how.
- Arnaldo
next prev parent reply other threads:[~2017-01-03 18:39 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 9:00 New attempt at adding an disassembler to perf Andi Kleen
2017-01-03 9:00 ` [PATCH 1/4] perf, tools: Add probing for xed Andi Kleen
2017-01-03 14:58 ` Jiri Olsa
2017-01-03 15:10 ` Arnaldo Carvalho de Melo
2017-01-03 15:11 ` Andi Kleen
2017-01-03 18:39 ` Arnaldo Carvalho de Melo [this message]
2017-01-03 19:48 ` Jiri Olsa
2017-01-08 14:19 ` Jiri Olsa
2017-01-08 14:20 ` Jiri Olsa
2017-01-10 0:56 ` Andi Kleen
2017-01-03 9:00 ` [PATCH 2/4] perf, tools: Add disassembler for x86 using the XED library Andi Kleen
2017-01-08 14:20 ` Jiri Olsa
2017-01-03 9:00 ` [PATCH 3/4] perf, tools, script: Add support for printing assembler Andi Kleen
2017-01-03 9:00 ` [PATCH 4/4] perf, tools, script: Add brstackasm output for branch stacks Andi Kleen
2017-01-08 14:19 ` Jiri Olsa
2017-01-09 19:14 ` Andi Kleen
2017-01-08 14:20 ` Jiri Olsa
2017-01-08 14:21 ` New attempt at adding an disassembler to perf Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103183946.GK27864@kernel.org \
--to=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.