From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Felipe Balbi <balbi@kernel.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: ohci-omap: defer probe if PHY is missing
Date: Tue, 3 Jan 2017 20:05:04 +0100 [thread overview]
Message-ID: <20170103190504.GA10352@kroah.com> (raw)
In-Reply-To: <20170103185031.viic6w5tzshb7mt5@raspberrypi-2.musicnaut.iki.fi>
On Tue, Jan 03, 2017 at 08:50:31PM +0200, Aaro Koskinen wrote:
> Hi,
>
> On Tue, Jan 03, 2017 at 05:51:43PM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Jan 02, 2017 at 10:53:55PM +0200, Aaro Koskinen wrote:
> > > Defer probe if PHY is missing. E.g. on Nokia 770 several modules needs
> > > to be loaded to get the PHY going and ohci-omap should wait for those.
> > >
> > > Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> >
> > Is this a new bug? The 770 has been around for forever, why has this
> > not been a problem before now?
>
> PHY/OTG support for 770 has been around only since v3.14.
3.14 was released March, 2014. A long time ago in kernel development :)
> I was previously compiling phy-tahvo as built-in, and bumped into this
> issue when compiling it as a module.
Why not just make the defconfig as built-in?
I'm not objecting to this patch, just really curious why no one else has
ever hit it.
thanks,
greg k-h
next prev parent reply other threads:[~2017-01-03 19:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-02 20:53 [PATCH] USB: ohci-omap: defer probe if PHY is missing Aaro Koskinen
[not found] ` <20170102205355.18920-1-aaro.koskinen-X3B1VOXEql0@public.gmane.org>
2017-01-03 16:51 ` Greg Kroah-Hartman
2017-01-03 16:51 ` Greg Kroah-Hartman
2017-01-03 18:50 ` Aaro Koskinen
2017-01-03 19:05 ` Greg Kroah-Hartman [this message]
[not found] ` <20170103190504.GA10352-U8xfFu+wG4EAvxtiuMwx3w@public.gmane.org>
2017-01-03 19:11 ` Felipe Balbi
2017-01-03 19:11 ` Felipe Balbi
2017-01-03 20:12 ` Aaro Koskinen
2017-01-03 20:12 ` Aaro Koskinen
2017-01-04 17:41 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103190504.GA10352@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=aaro.koskinen@iki.fi \
--cc=balbi@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.