From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935739AbdACUJt (ORCPT ); Tue, 3 Jan 2017 15:09:49 -0500 Received: from vps0.lunn.ch ([178.209.37.122]:42082 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933629AbdACUJe (ORCPT ); Tue, 3 Jan 2017 15:09:34 -0500 Date: Tue, 3 Jan 2017 21:09:14 +0100 From: Andrew Lunn To: Florian Fainelli , John Crispin Cc: Vivien Didelot , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , cphealy@gmail.com Subject: Re: [PATCH net-next 0/3] net: dsa: restore HWMON support in dsa2 Message-ID: <20170103200914.GB8765@lunn.ch> References: <20170103181538.2593-1-vivien.didelot@savoirfairelinux.com> <20170103183352.GA30638@lunn.ch> <87ful0eylp.fsf@weeman.i-did-not-set--mail-host-address--so-tickle-me> <0a504cad-2f2c-fc6a-9965-5ae87be9dac4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0a504cad-2f2c-fc6a-9965-5ae87be9dac4@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Well, I agree with the regression part, but an argument could > definitively be made that HWMON did not belong in the DSA layer in the > first place, unless we were able to find some commonality between > devices which AFAICT, we could not yet. Florian, does SF2 or b53 have a temperature sensor? John, does the qca8k have a temperature sensor? If we do have a switch with a temperature sensor, making the HWMON code available as a library for switch drivers to use makes sense. However, if we move the Marvell code into the PHY driver, and there are no other switches with temperature sensors, we should just remove it. Andrew