From: Guenter Roeck <linux@roeck-us.net>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "wim@iguana.be" <wim@iguana.be>,
"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: Auto-conversion of watchdog drivers to use devm functions
Date: Tue, 3 Jan 2017 16:11:45 -0800 [thread overview]
Message-ID: <20170104001145.GA15099@roeck-us.net> (raw)
In-Reply-To: <CAHp75VcPRkscW8MaM3-nO-tzJnuC9f2fa3wc6oODo_aq+9Wdcg@mail.gmail.com>
On Wed, Jan 04, 2017 at 01:55:39AM +0200, Andy Shevchenko wrote:
> On Mon, Jan 2, 2017 at 1:53 AM, Guenter Roeck <linux@roeck-us.net> wrote:
> > Hi Wim,
> >
> > With heavy support by Julia Lawall, I created a number of coccinelle scripts
> > to auto-convert watchdog platform drivers to use devm functions. The result
> > is quite impressive - many drivers won't even need remove functions anymore
> > after the conversion.
> >
> > Question is now how to submit the patches. There are 12 rule files affecting
> > a total of 62 drivers. Should I submit one patch per driver (62 patches),
> > one patch per rule (12), or one patch per rule file per driver (183) ?
>
> One per driver.
>
> > Also, how should I refer to the rules ? The total number of rule lines
> > is more than 1,000, which seems to be a bit much for the commit log (even
> > though not all rules apply to all files).
>
> No need, perhaps some URL?
>
Yes, that is what I ended up doing - I created a repository on github and
pushed the semantic patches as well as the scripts used to generate the
actual patches into it. I am going to reference that repository in the
patches, together with a summary of the changes made.
An interesting exercise is to let the semantic patches run on the entire
kernel. It generates almost 1,500 patches.
Thanks,
Guenter
prev parent reply other threads:[~2017-01-04 0:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-01 23:53 Auto-conversion of watchdog drivers to use devm functions Guenter Roeck
2017-01-03 23:55 ` Andy Shevchenko
2017-01-04 0:11 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104001145.GA15099@roeck-us.net \
--to=linux@roeck-us.net \
--cc=andy.shevchenko@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.