From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Charles (Chas) Williams" <ciwillia@brocade.com>
Cc: dev@dpdk.org, mtetsuyah@gmail.com, stable@dpdk.org
Subject: Re: [PATCH v4 1/2] net/vhost: create datagram sockets immediately
Date: Wed, 4 Jan 2017 16:06:31 +0800 [thread overview]
Message-ID: <20170104080631.GM21228@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <1483460563-5003-1-git-send-email-ciwillia@brocade.com>
On Tue, Jan 03, 2017 at 11:22:42AM -0500, Charles (Chas) Williams wrote:
> If you create a vhost server device, it doesn't create the actual datagram
> socket until you call .dev_start(). If you call .dev_stop() is also
> deletes those sockets. For QEMU clients, this is a problem since QEMU
> doesn't know how to re-attach to datagram sockets that have gone away.
>
> To fix this, register and unregister the datagram sockets during device
> creation and removal.
>
> Fixes: ee584e9710b9 ("vhost: add driver on top of the library")
Both patches applied to dpdk-next-virtio. Thanks!
Note that we prefer a title of "prefix: fix ..." for bug fixing patch.
For this reason, I have changed the title for you while apply:
net/vhost: fix socket file being deleted on dev stop
Also, stable is cc'ed.
--yliu
prev parent reply other threads:[~2017-01-04 8:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-03 16:22 [PATCH v4 1/2] net/vhost: create datagram sockets immediately Charles (Chas) Williams
2017-01-03 16:22 ` [PATCH v4 2/2] net/vhost: emulate device start/stop behavior Charles (Chas) Williams
2017-01-04 8:06 ` Yuanhan Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104080631.GM21228@yliu-dev.sh.intel.com \
--to=yuanhan.liu@linux.intel.com \
--cc=ciwillia@brocade.com \
--cc=dev@dpdk.org \
--cc=mtetsuyah@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.