From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966311AbdADJD7 (ORCPT ); Wed, 4 Jan 2017 04:03:59 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:57978 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966221AbdADJDz (ORCPT ); Wed, 4 Jan 2017 04:03:55 -0500 Date: Wed, 4 Jan 2017 10:04:16 +0100 From: Greg KH To: Stuart Yoder Cc: "devel@driverdev.osuosl.org" , "arnd@arndb.de" , Roy Pledge , Alexandru Marginean , "linux-kernel@vger.kernel.org" , "agraf@suse.de" , Bogdan Hamciuc , Laurentiu Tudor Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file Message-ID: <20170104090416.GC30722@kroah.com> References: <20161206093442.11362-1-ruxandra.radulescu@nxp.com> <20161206093442.11362-8-ruxandra.radulescu@nxp.com> <20161206095800.GA4247@kroah.com> <20161206102014.GA7899@kroah.com> <20161206175555.GB15607@kroah.com> <20170103164746.GA24790@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 03, 2017 at 09:26:46PM +0000, Stuart Yoder wrote: > > > -----Original Message----- > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > Sent: Tuesday, January 03, 2017 10:48 AM > > To: Stuart Yoder > > Cc: devel@driverdev.osuosl.org; arnd@arndb.de; Roy Pledge ; Alexandru Marginean > > ; linux-kernel@vger.kernel.org; agraf@suse.de; Bogdan Hamciuc > > ; Laurentiu Tudor > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > On Tue, Dec 06, 2016 at 06:10:38PM +0000, Stuart Yoder wrote: > > > > > > > > > > -----Original Message----- > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > Sent: Tuesday, December 06, 2016 11:56 AM > > > > To: Stuart Yoder > > > > Cc: Ruxandra Ioana Radulescu ; devel@driverdev.osuosl.org; linux- > > > > kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; Alexandru Marginean > > ; > > > > Bogdan Hamciuc ; Roy Pledge ; Laurentiu Tudor > > > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > On Tue, Dec 06, 2016 at 12:59:59PM +0000, Stuart Yoder wrote: > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > > Sent: Tuesday, December 06, 2016 4:20 AM > > > > > > To: Ruxandra Ioana Radulescu > > > > > > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; agraf@suse.de; arnd@arndb.de; > > > > Alexandru > > > > > > Marginean ; Bogdan Hamciuc ; Stuart Yoder > > > > > > ; Roy Pledge ; Laurentiu Tudor > > > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > > > On Tue, Dec 06, 2016 at 10:06:25AM +0000, Ruxandra Ioana Radulescu wrote: > > > > > > > > -----Original Message----- > > > > > > > > From: Greg KH [mailto:gregkh@linuxfoundation.org] > > > > > > > > Sent: Tuesday, December 06, 2016 11:58 AM > > > > > > > > To: Ruxandra Ioana Radulescu > > > > > > > > Cc: devel@driverdev.osuosl.org; linux-kernel@vger.kernel.org; > > > > > > > > agraf@suse.de; arnd@arndb.de; Alexandru Marginean > > > > > > > > ; Bogdan Hamciuc > > > > > > > > ; Stuart Yoder ; Roy > > > > > > > > Pledge ; Laurentiu Tudor > > > > > > > > > > > > > > > > Subject: Re: [PATCH 7/8] staging: fsl-dpaa2/eth: Add TODO file > > > > > > > > > > > > > > > > On Tue, Dec 06, 2016 at 03:34:41AM -0600, Ioana Radulescu wrote: > > > > > > > > > Add a list of TODO items for the Ethernet driver > > > > > > > > > > > > > > > > > > Signed-off-by: Ioana Radulescu > > > > > > > > > --- > > > > > > > > > drivers/staging/fsl-dpaa2/ethernet/TODO | 9 +++++++++ > > > > > > > > > 1 files changed, 9 insertions(+), 0 deletions(-) > > > > > > > > > create mode 100644 drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > > > > > > > > > > > diff --git a/drivers/staging/fsl-dpaa2/ethernet/TODO b/drivers/staging/fsl- > > > > > > > > dpaa2/ethernet/TODO > > > > > > > > > new file mode 100644 > > > > > > > > > index 0000000..833265b > > > > > > > > > --- /dev/null > > > > > > > > > +++ b/drivers/staging/fsl-dpaa2/ethernet/TODO > > > > > > > > > @@ -0,0 +1,9 @@ > > > > > > > > > +* Add a DPAA2 MAC kernel driver in order to allow PHY management; > > > > > > > > currently > > > > > > > > > + the DPMAC objects and their link to DPNIs are handled by MC internally > > > > > > > > > + and all PHYs are seen as fixed-link > > > > > > > > > +* add more debug support: decide how to expose detailed debug > > > > > > > > statistics, > > > > > > > > > + add ingress error queue support > > > > > > > > > +* MC firmware uprev; the DPAA2 objects used by the Ethernet driver > > > > > > > > need to > > > > > > > > > + be kept in sync with binary interface changes in MC > > > > > > > > > +* refine README file > > > > > > > > > +* cleanup > > > > > > > > > > > > > > > > These seem like very minor things, why not just spend a week and do this > > > > > > > > work and get it merged to the "correct" portion of the kernel tree? Why > > > > > > > > does this have to go into staging? > > > > > > > > > > > > > > Actually the first bullet is not minor at all and requires some design > > > > > > > choices that we aren't yet completely clear with, and which in turn may > > > > > > > affect parts of the Ethernet driver. We figured it would be best to try > > > > > > > adding this in staging first (and also provide this way an example of using > > > > > > > the fsl-mc bus and dpio driver) than wait until all MAC development > > > > > > > questions are ironed-out. > > > > > > > > > > > > Ok, that makes sense. > > > > > > > > > > > > > I can remove the other bullets from the TODO list if you think they're > > > > > > > not worth mentioning. > > > > > > > > > > > > No, they should be mentioned, I just didn't think they are all that much > > > > > > work, and if you didn't have major things needed to get done, you could > > > > > > just knock it all out in a week of local development. > > > > > > > > > > > > I'll look into taking this into the tree later today... > > > > > > > > > > Note, as mentioned in the cover letter, in it's current form this patch > > > > > series is based on the series: > > > > > [PATCH v3 0/9] staging: fsl-mc: move bus driver out of staging, add dpio > > > > > > > > > > ...which means that it won't build or run without that series being > > > > > applied first, due to header file dependencies. It also functionally > > > > > depends on the DPIO driver. So we need the dpio driver merged first. > > > > > > > > > > Is moving the fsl-mc bus driver out of staging a possibility now? > > > > > > > > I'm ok with it, but I really haven't looked at the patches in a while, I > > > > keep seeing others have problems with it. Want me to review it now? > > > > > > Yes, would like that very much. > > > > Ok, basic driver model things, who is cleaning up your struct devices > > when they go away? Don't you get nasty warnings from the driver core > > when the device is removed? > > Thanks, you had some similar comments back in December: > https://lkml.org/lkml/2016/12/8/364 Hey, at least I'm consistant! I totally forgot I had reviewed this before, that must mean something... > Device removal works, but we are not getting warnings because the > ref count never goes to zero...so something is wrong and > we are debugging and will refactoring. Oh good, I'll drop all of these patches and wait for your fixes. thanks, greg k-h