From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758428AbdADJli (ORCPT ); Wed, 4 Jan 2017 04:41:38 -0500 Received: from bombadil.infradead.org ([198.137.202.9]:45611 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750851AbdADJlg (ORCPT ); Wed, 4 Jan 2017 04:41:36 -0500 Date: Wed, 4 Jan 2017 10:39:19 +0100 From: Peter Zijlstra To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, mingo@kernel.org, hpa@zytor.com, linux-tip-commits@vger.kernel.org Subject: Re: [tip:timers/urgent] ktime: Get rid of the union Message-ID: <20170104093919.GC25813@worktop.programming.kicks-ass.net> References: <20170103103634.GA25813@worktop.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22.1 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 04, 2017 at 09:54:12AM +0100, Thomas Gleixner wrote: > On Tue, 3 Jan 2017, Peter Zijlstra wrote: > > > Get rid of the union and just keep ktime_t as simple typedef of type s64. > > > > All good stuff. One question that remains is why keep the type while > > removing the cycles_t type? > > That would have been a massive surgery which I was not able to pull off on > top of the other changes. And the reason ktime needs be s64 is because 0 is at boot, and we need to represent time before boot, right? Might want to stick that in a comment somewhere near that typedef, so I don't keep asking this ;-)