From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Engestrom Subject: Re: [PATCH v2] drm: add fourcc codes for 16bit R and GR Date: Wed, 4 Jan 2017 10:19:18 +0000 Message-ID: <20170104101918.GE2136@imgtec.com> References: <20170103190207.4569-1-fernetmenta@kodi.tv> <20170104085201.av3shack7hd74ubs@phenom.ffwll.local> <87y3yrgpoe.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <87y3yrgpoe.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Rainer Hochecker Cc: ben@bwidawsk.net, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, fernetmenta@online.de List-Id: dri-devel@lists.freedesktop.org T24gV2VkbmVzZGF5LCAyMDE3LTAxLTA0IDExOjA2OjA5ICswMjAwLCBKYW5pIE5pa3VsYSB3cm90 ZToKPiBPbiBXZWQsIDA0IEphbiAyMDE3LCBEYW5pZWwgVmV0dGVyIDxkYW5pZWxAZmZ3bGwuY2g+ IHdyb3RlOgo+ID4gT24gVHVlLCBKYW4gMDMsIDIwMTcgYXQgMDg6MDI6MDdQTSArMDEwMCwgUmFp bmVyIEhvY2hlY2tlciB3cm90ZToKPiA+PiBGcm9tOiBSYWluZXIgSG9jaGVja2VyIDxmZXJuZXRt ZW50YUBvbmxpbmUuZGU+Cj4gPj4gCj4gPj4gTm93IHNlbnQgd2l0aCBnaXQgc2VuZC1lbWFpbDoK PiA+PiAKPiA+PiBTaWduZWQtb2ZmLWJ5OiBSYWluZXIgSG9jaGVja2VyIDxmZXJuZXRtZW50YUBv bmxpbmUuZGU+Cj4gPj4gLS0tCj4gPj4gIGluY2x1ZGUvdWFwaS9kcm0vZHJtX2ZvdXJjYy5oIHwg NyArKysrKysrCj4gPj4gIDEgZmlsZSBjaGFuZ2VkLCA3IGluc2VydGlvbnMoKykKPiA+PiAKPiA+ PiBkaWZmIC0tZ2l0IGEvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmggYi9pbmNsdWRlL3Vh cGkvZHJtL2RybV9mb3VyY2MuaAo+ID4+IGluZGV4IGE1ODkwYmYuLmYxZWY5Y2IgMTAwNjQ0Cj4g Pj4gLS0tIGEvaW5jbHVkZS91YXBpL2RybS9kcm1fZm91cmNjLmgKPiA+PiArKysgYi9pbmNsdWRl L3VhcGkvZHJtL2RybV9mb3VyY2MuaAo+ID4+IEBAIC00MSwxMCArNDEsMTcgQEAgZXh0ZXJuICJD IiB7Cj4gPj4gIC8qIDggYnBwIFJlZCAqLwo+ID4+ICAjZGVmaW5lIERSTV9GT1JNQVRfUjgJCWZv dXJjY19jb2RlKCdSJywgJzgnLCAnICcsICcgJykgLyogWzc6MF0gUiAqLwo+ID4+ICAKPiA+PiAr LyogMTYgYnBwIFJlZCAqLwo+ID4+ICsjZGVmaW5lIERSTV9GT1JNQVRfUjE2CQlmb3VyY2NfY29k ZSgnUicsICcxJywgJzYnLCAnICcpIC8qIFsxNTowXSBSICovCj4gPj4gKwo+ID4+ICAvKiAxNiBi cHAgUkcgKi8KPiA+PiAgI2RlZmluZSBEUk1fRk9STUFUX1JHODgJCWZvdXJjY19jb2RlKCdSJywg J0cnLCAnOCcsICc4JykgLyogWzE1OjBdIFI6RyA4OjggbGl0dGxlIGVuZGlhbiAqLwo+ID4+ICAj ZGVmaW5lIERSTV9GT1JNQVRfR1I4OAkJZm91cmNjX2NvZGUoJ0cnLCAnUicsICc4JywgJzgnKSAv KiBbMTU6MF0gRzpSIDg6OCBsaXR0bGUgZW5kaWFuICovCj4gPj4gIAo+ID4+ICsvKiAzMiBicHAg R1IgKi8KPiA+PiArI2RlZmluZSBEUk1fRk9STUFUX1JHMzIJCWZvdXJjY19jb2RlKCdSJywgJ0cn LCAnMycsICcyJykgLyogWzMxOjBdIEc6UiAxNjoxNiBsaXR0bGUgZW5kaWFuICovCgpBbHNvLCBz L0c6Ui9SOkcvIGluIHRoZSBjb21tZW50IGFib3ZlIDopCgo+ID4+ICsjZGVmaW5lIERSTV9GT1JN QVRfR1IzMgkJZm91cmNjX2NvZGUoJ0cnLCAnUicsICczJywgJzInKSAvKiBbMzE6MF0gRzpSIDE2 OjE2IGxpdHRsZSBlbmRpYW4gKi8KPiA+Cj4gPiBOb3cgdGhlIGRlZmluZSdzIG5hbWUgaXMgaW5j b25zaXN0ZW50LCBzaW5jZSB0aGF0IHdvdWxkIHN1Z2dlc3QgYSA1IGJwcAo+ID4gZm9ybWF0IHdp dGggMyBiaXRzIGZvciBSIGFuZCAyIGJpdHMgZm9yIEcuIEkgdGhpbmsgd2hhdCB3ZSB3YW50IGhl cmUgZm9yCj4gPiBjb25zaXN0ZW5jeSBpcyBfUkcxNl8xNiBhbmQgX0dSMTZfMTYsIGFsb25nIHRo ZSBsaW5lcyBvZiB3aGF0IFZpbGxlCj4gPiBzdWdnZXN0ZWQuCj4gPgo+ID4gU29ycnkgdGhhdCB0 aGlzIGlzIHN1Y2ggYSBiaWtlc2hlZCBoZWF2ZW4gOy0pCj4gCj4gSWYgdGhlcmUncyBnb2luZyB0 byBiZSBhbm90aGVyIHZlcnNpb24sIHBsZWFzZSBmaXggdGhlIGNvbW1pdCBtZXNzYWdlCj4gd2hp bGUgYXQgaXQuICJOb3cgc2VudCB3aXRoIGdpdCBzZW5kLWVtYWlsIiBpcyB1c2VsZXNzIGZvciBw b3N0ZXJpdHkuCj4gCj4gQlIsCj4gSmFuaS4KPiAKPiAKPiA+IC1EYW5pZWwKPiA+Cj4gPj4gKwo+ ID4+ICAvKiA4IGJwcCBSR0IgKi8KPiA+PiAgI2RlZmluZSBEUk1fRk9STUFUX1JHQjMzMglmb3Vy Y2NfY29kZSgnUicsICdHJywgJ0InLCAnOCcpIC8qIFs3OjBdIFI6RzpCIDM6MzoyICovCj4gPj4g ICNkZWZpbmUgRFJNX0ZPUk1BVF9CR1IyMzMJZm91cmNjX2NvZGUoJ0InLCAnRycsICdSJywgJzgn KSAvKiBbNzowXSBCOkc6UiAyOjM6MyAqLwo+ID4+IC0tIAo+ID4+IDIuOS4zCj4gPj4gCj4gCj4g LS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2VudGVyCl9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBt YWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3Rz LmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935913AbdADKUO (ORCPT ); Wed, 4 Jan 2017 05:20:14 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:52179 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751356AbdADKUH (ORCPT ); Wed, 4 Jan 2017 05:20:07 -0500 Date: Wed, 4 Jan 2017 10:19:18 +0000 From: Eric Engestrom To: Rainer Hochecker CC: Daniel Vetter , Jani Nikula , , , , , Subject: Re: [Intel-gfx] [PATCH v2] drm: add fourcc codes for 16bit R and GR Message-ID: <20170104101918.GE2136@imgtec.com> References: <20170103190207.4569-1-fernetmenta@kodi.tv> <20170104085201.av3shack7hd74ubs@phenom.ffwll.local> <87y3yrgpoe.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <87y3yrgpoe.fsf@intel.com> User-Agent: Mutt/1.7.2 (2016-11-26) X-Originating-IP: [10.60.4.28] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, 2017-01-04 11:06:09 +0200, Jani Nikula wrote: > On Wed, 04 Jan 2017, Daniel Vetter wrote: > > On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote: > >> From: Rainer Hochecker > >> > >> Now sent with git send-email: > >> > >> Signed-off-by: Rainer Hochecker > >> --- > >> include/uapi/drm/drm_fourcc.h | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h > >> index a5890bf..f1ef9cb 100644 > >> --- a/include/uapi/drm/drm_fourcc.h > >> +++ b/include/uapi/drm/drm_fourcc.h > >> @@ -41,10 +41,17 @@ extern "C" { > >> /* 8 bpp Red */ > >> #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ > >> > >> +/* 16 bpp Red */ > >> +#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R */ > >> + > >> /* 16 bpp RG */ > >> #define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */ > >> #define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */ > >> > >> +/* 32 bpp GR */ > >> +#define DRM_FORMAT_RG32 fourcc_code('R', 'G', '3', '2') /* [31:0] G:R 16:16 little endian */ Also, s/G:R/R:G/ in the comment above :) > >> +#define DRM_FORMAT_GR32 fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */ > > > > Now the define's name is inconsistent, since that would suggest a 5 bpp > > format with 3 bits for R and 2 bits for G. I think what we want here for > > consistency is _RG16_16 and _GR16_16, along the lines of what Ville > > suggested. > > > > Sorry that this is such a bikeshed heaven ;-) > > If there's going to be another version, please fix the commit message > while at it. "Now sent with git send-email" is useless for posterity. > > BR, > Jani. > > > > -Daniel > > > >> + > >> /* 8 bpp RGB */ > >> #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */ > >> #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */ > >> -- > >> 2.9.3 > >> > > -- > Jani Nikula, Intel Open Source Technology Center