From: Krister Johansen <kjlx@templeofstupid.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Krister Johansen <kjlx@templeofstupid.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] Introduce a sysctl that modifies the value of PROT_SOCK.
Date: Wed, 4 Jan 2017 02:19:27 -0800 [thread overview]
Message-ID: <20170104101927.GG3009@templeofstupid.com> (raw)
In-Reply-To: <20161231125505.7f0c7dff@xeon-e3>
On Sat, Dec 31, 2016 at 12:55:05PM -0800, Stephen Hemminger wrote:
> On Fri, 30 Dec 2016 20:11:11 -0800
> Krister Johansen <kjlx@templeofstupid.com> wrote:
>
> >
> > +config LOWPORT_SYSCTL
> > + bool "Adjust reserved port range via sysctl"
> > + depends on SYSCTL
> > + help
> > + This allows the administrator to adjust the reserved port range
> > + using a sysctl.
>
> This looks like a good idea, and makes a lot of sense.
>
> Please don't introduce yet another config option. All distro's will enable it anyway.
> Having more config options doesn't help reliability or testability.
>
> Do or do not, please no new config options.
I'd be happy to take it out. It simplifies things for me. I had
anticipated that there would be objections to permitting software to get
around the current priviliged port restrictions, and thought that
perhaps as a compromise having it be compile time option would ease some
of those concerns.
-K
next prev parent reply other threads:[~2017-01-04 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-31 4:11 [PATCH] Introduce a sysctl that modifies the value of PROT_SOCK Krister Johansen
2016-12-31 20:55 ` Stephen Hemminger
2017-01-04 10:19 ` Krister Johansen [this message]
2017-01-12 6:52 ` [PATCH v2 net-next] " Krister Johansen
2017-01-12 14:22 ` David Miller
2017-01-14 0:13 ` Krister Johansen
2017-01-12 14:39 ` Eric Dumazet
2017-01-14 0:11 ` Krister Johansen
2017-01-21 1:49 ` [PATCH v3 " Krister Johansen
2017-01-23 20:39 ` David Miller
2017-01-24 17:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170104101927.GG3009@templeofstupid.com \
--to=kjlx@templeofstupid.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.